Merge pull request #10429 from ethereum/fix-and-enable-external-tests

Fix and enable external tests

.circleci/config.yml

@@ -820,7 +820,7 @@ jobs:
 
   t_ems_compile_ext_gnosis:
     docker:
-      - image: circleci/node:10
+      - image: circleci/node:14
     environment:
       TERM: xterm
     steps:
@@ -835,7 +835,8 @@ jobs:
 
   t_ems_test_ext_gnosis:
     docker:
-      - image: circleci/node:10
+      # NOTE: Tests do not start on node.js 14 ("ganache-cli exited early with code 1").
+      - image: circleci/node:12
     environment:
       TERM: xterm
     steps:
@@ -845,13 +846,47 @@ jobs:
       - run:
           name: External GnosisSafe tests
           command: |
-            test/externalTests/gnosis.sh /tmp/workspace/soljson.js || test/externalTests/gnosis.sh /tmp/workspace/soljson.js
-      - run: *gitter_notify_failure
-      - run: *gitter_notify_success
+            test/externalTests/gnosis.sh /tmp/workspace/soljson.js
+      # TODO: Re-enable notifications once this is running nightly rather than as a PR check
+      #- run: *gitter_notify_failure
+      #- run: *gitter_notify_success
+
+  t_ems_compile_ext_gnosis_v2:
+    docker:
+      - image: circleci/node:14
+    environment:
+      TERM: xterm
+    steps:
+      - checkout
+      - attach_workspace:
+          at: /tmp/workspace
+      - run:
+          name: External GnosisSafe v2 compilation
+          command: |
+            export COMPILE_ONLY=1
+            test/externalTests/gnosis-v2.sh /tmp/workspace/soljson.js
+
+  t_ems_test_ext_gnosis_v2:
+    docker:
+      # NOTE: Tests do not start on node.js 14 ("ganache-cli exited early with code 1").
+      - image: circleci/node:12
+    environment:
+      TERM: xterm
+    steps:
+      - checkout
+      - attach_workspace:
+          at: /tmp/workspace
+      - run:
+          name: External GnosisSafe v2 tests
+          command: |
+            test/externalTests/gnosis-v2.sh /tmp/workspace/soljson.js
+      # TODO: Re-enable notifications once this is running nightly rather than as a PR check
+      #- run: *gitter_notify_failure
+      #- run: *gitter_notify_success
 
   t_ems_compile_ext_zeppelin:
     docker:
-      - image: circleci/node:10
+      - image: circleci/node:14
     environment:
       TERM: xterm
     steps:
@@ -866,7 +901,7 @@ jobs:
 
   t_ems_test_ext_zeppelin:
     docker:
-      - image: circleci/node:10
+      - image: circleci/node:14
     environment:
       TERM: xterm
     steps:
@@ -876,13 +911,14 @@ jobs:
       - run:
           name: External Zeppelin tests
           command: |
-            test/externalTests/zeppelin.sh /tmp/workspace/soljson.js || test/externalTests/zeppelin.sh /tmp/workspace/soljson.js
-      - run: *gitter_notify_failure
-      - run: *gitter_notify_success
+            test/externalTests/zeppelin.sh /tmp/workspace/soljson.js
+      # TODO: Re-enable notifications once this is running nightly rather than as a PR check
+      #- run: *gitter_notify_failure
+      #- run: *gitter_notify_success
 
   t_ems_compile_ext_colony:
     docker:
-      - image: circleci/node:10
+      - image: circleci/node:14
     environment:
       TERM: xterm
     steps:
@@ -901,7 +937,7 @@ jobs:
 
   t_ems_test_ext_colony:
     docker:
-      - image: circleci/node:10
+      - image: circleci/node:14
     environment:
       TERM: xterm
     steps:
@@ -915,12 +951,14 @@ jobs:
       - run:
           name: External ColonyNetworks tests
           command: |
-            test/externalTests/colony.sh /tmp/workspace/soljson.js || test/externalTests/colony.sh /tmp/workspace/soljson.js
-      - run: *gitter_notify_failure
-      - run: *gitter_notify_success
+            test/externalTests/colony.sh /tmp/workspace/soljson.js
+      # TODO: Re-enable notifications once this is running nightly rather than as a PR check
+      #- run: *gitter_notify_failure
+      #- run: *gitter_notify_success
 
   t_ems_compile_ext_ens:
     docker:
+      # NOTE: One of the dependencies (fsevents) fails to build its native extension on node.js 12+.
       - image: circleci/node:10
     environment:
       TERM: xterm
@@ -938,6 +976,28 @@ jobs:
             export COMPILE_ONLY=1
             test/externalTests/ens.sh /tmp/workspace/soljson.js
 
+  t_ems_test_ext_ens:
+    docker:
+      # NOTE: One of the dependencies (fsevents) fails to build its native extension on node.js 12+.
+      - image: circleci/node:10
+    environment:
+      TERM: xterm
+    steps:
+      - checkout
+      - attach_workspace:
+          at: /tmp/workspace
+      - run:
+          name: Install test dependencies
+          command: |
+            sudo apt-get -qy install lsof
+      - run:
+          name: External Ens compilation
+          command: |
+            test/externalTests/ens.sh /tmp/workspace/soljson.js
+      # TODO: Re-enable notifications once this is running nightly rather than as a PR check
+      #- run: *gitter_notify_failure
+      #- run: *gitter_notify_success
+
   b_win: &b_win
     executor:
       name: win/default
@@ -1121,8 +1181,16 @@ workflows:
       - t_ems_solcjs: *workflow_emscripten
       - t_ems_compile_ext_colony: *workflow_emscripten
       - t_ems_compile_ext_gnosis: *workflow_emscripten
+      - t_ems_compile_ext_gnosis_v2: *workflow_emscripten
       - t_ems_compile_ext_zeppelin: *workflow_emscripten
       - t_ems_compile_ext_ens: *workflow_emscripten
+      - t_ems_test_ext_colony: *workflow_emscripten
+      # FIXME: Gnosis tests are pretty flaky right now. They often fail on CircleCI due to random ProviderError
+      # and there are also other less frequent problems. See https://github.com/gnosis/safe-contracts/issues/216.
+      #- t_ems_test_ext_gnosis: *workflow_emscripten
+      - t_ems_test_ext_gnosis_v2: *workflow_emscripten
+      - t_ems_test_ext_zeppelin: *workflow_emscripten
+      - t_ems_test_ext_ens: *workflow_emscripten
 
       # Windows build and tests
       - b_win: *workflow_trigger_on_tags