cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #10964 from ethereum/test-yul-func

Browse Source 
Turn unreachable error into assertion
This commit is contained in:
chriseth 2021-02-16 13:33:11 +01:00 committed by GitHub
commit 859220c9bd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libyul/AsmAnalysis.cpp
View File

@ -530,10 +530,11 @@ void AsmAnalyzer::checkAssignment(Identifier const& _variable, YulString _valueT
bool found = false;
if (Scope::Identifier const* var = m_currentScope->lookup(_variable.name))
{
// Check that it is a variable
if (!holds_alternative<Scope::Variable>(*var))
m_errorReporter.typeError(2657_error, _variable.location, "Assignment requires variable.");
else if (!m_activeVariables.count(&std::get<Scope::Variable>(*var)))
// Check that it is a variable.
// This can also hold a function, but that is caught by error 6041.
yulAssert(holds_alternative<Scope::Variable>(*var), "Assignment requires variable.");
if (!m_activeVariables.count(&std::get<Scope::Variable>(*var)))
m_errorReporter.declarationError(
1133_error,
_variable.location,

2
scripts/error_codes.py
View File

@ -221,7 +221,7 @@ def examine_id_coverage(top_dir, source_id_to_file_names, new_ids_only=False):
old_source_only_ids = {
"1584", "1823",
"1988", "2066", "2657", "2800", "3356",
"1988", "2066", "2800", "3356",
"3893", "3996", "4010", "4802",
"5073", "5272", "5622", "7128",
"7589", "7593", "8065", "8084", "8140",