From b3f35f703aa5d2f55cff36b9a6f16c0ac7d44849 Mon Sep 17 00:00:00 2001 From: Peter Lemenkov Date: Sat, 4 Feb 2023 16:16:54 +0100 Subject: [PATCH] libsolidity: Redundant std::move This patch suppresses warnings like this one: ``` /builddir/build/BUILD/solidity-0.8.18/libsolidity/ast/AST.h: In constructor 'solidity::frontend::FunctionDefinition::FunctionDefinition(int64_t, const solidity::frontend::ASTNode::SourceLocation&, solidity::frontend::ASTPointer >&, const solidity::frontend::ASTNode::SourceLocation&, solidity::frontend::Visibility, solidity::frontend::StateMutability, bool, solidity::langutil::Token, bool, solidity::frontend::ASTPointer&, solidity::frontend::ASTPointer&, solidity::frontend::ASTPointer&, std::vector >, solidity::frontend::ASTPointer&, solidity::frontend::ASTPointer&)': /builddir/build/BUILD/solidity-0.8.18/libsolidity/ast/AST.h:926:69: error: redundant move in initialization [-Werror=redundant-move] 926 | CallableDeclaration(_id, _location, _name, std::move(_nameLocation), _visibility, _parameters, _isVirtual, _overrides, _returnParameters), | ~~~~~~~~~^~~~~~~~~~~~~~~ /builddir/build/BUILD/solidity-0.8.18/libsolidity/ast/AST.h:926:69: note: remove 'std::move' call ``` Signed-off-by: Peter Lemenkov --- libsolidity/ast/AST.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libsolidity/ast/AST.h b/libsolidity/ast/AST.h index 06575beec..f0f43945b 100644 --- a/libsolidity/ast/AST.h +++ b/libsolidity/ast/AST.h @@ -923,7 +923,7 @@ public: ASTPointer const& _returnParameters, ASTPointer const& _body ): - CallableDeclaration(_id, _location, _name, std::move(_nameLocation), _visibility, _parameters, _isVirtual, _overrides, _returnParameters), + CallableDeclaration(_id, _location, _name, _nameLocation, _visibility, _parameters, _isVirtual, _overrides, _returnParameters), StructurallyDocumented(_documentation), ImplementationOptional(_body != nullptr), m_stateMutability(_stateMutability),