cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add test: operator_parameter_with_wrong_data_location

Browse Source
This commit is contained in:
wechman 2022-07-12 12:20:22 +02:00
parent 61075e28db
commit 8272da0aea
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
libsolidity/ast/Types.cpp
View File

@ -403,7 +403,6 @@ FunctionDefinition const* Type::userDefinedOperator(Token _token, ASTNode const&
function.libraryFunction() ? function.typeViaContractName() : function.type()
);
solAssert(functionType && !functionType->parameterTypes().empty());
// TODO does this work (data location)?
solAssert(isImplicitlyConvertibleTo(*functionType->parameterTypes().front()));
if ((_unaryOperation && function.parameterList().parameters().size() == 1) ||
(!_unaryOperation && function.parameterList().parameters().size() == 2))

10
test/libsolidity/syntaxTests/operators/custom/operator_parameter_with_wrong_data_location.sol Normal file
View File

@ -0,0 +1,10 @@
struct S { uint128 x; }
using {add as +} for S;
function add(S memory, S storage) returns (S memory) {
return S(0);
}
// ----
// TypeError 1884: (32-35): The function "add" needs to have two parameters of equal type to be used for the operator +.