cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #9514 from ethereum/fixInterCon

Browse Source 
Fix internal error for invalid data location in constructor.
This commit is contained in:
chriseth 2020-07-27 19:21:55 +02:00 committed by GitHub
commit 81cdc39f51
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libsolidity/analysis/DeclarationTypeChecker.cpp
View File

@ -324,7 +324,9 @@ void DeclarationTypeChecker::endVisit(VariableDeclaration const& _variable)
", ",
" or "
);
if (_variable.isCallableOrCatchParameter())
if (_variable.isConstructorParameter())
errorString += " for constructor parameter";
else if (_variable.isCallableOrCatchParameter())
errorString +=
" for " +
string(_variable.isReturnParameter() ? "return " : "") +

2
test/libsolidity/syntaxTests/constructor/calldata_constructor_args.sol
View File

@ -2,4 +2,4 @@ contract C {
constructor(uint[] calldata) public {}
}
// ----
// TypeError 6651: (29-44): Data location must be "storage" or "memory" for parameter in function, but "calldata" was given.
// TypeError 6651: (29-44): Data location must be "storage" or "memory" for constructor parameter, but "calldata" was given.

6
test/libsolidity/syntaxTests/dataLocations/unspecified_constructor.sol Normal file
View File

@ -0,0 +1,6 @@
contract C {
struct S {uint x;}
constructor(S) {}
}
// ----
// TypeError 6651: (48-49): Data location must be "storage" or "memory" for constructor parameter, but none was given.