cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Sol -> Yul] Enable function pointer comparison

Browse Source
This commit is contained in:
Mathias Baumann 2019-05-21 14:40:28 +02:00
parent e5902c58a4
commit 81702717b0
2 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libsolidity/codegen/ir/IRGeneratorForStatements.cpp
View File

@ -356,7 +356,12 @@ bool IRGeneratorForStatements::visit(BinaryOperation const& _binOp)
"\n"; "\n";
else if (TokenTraits::isCompareOp(op)) else if (TokenTraits::isCompareOp(op))
{ {
solUnimplementedAssert(commonType->category() != Type::Category::Function, ""); if (auto type = dynamic_cast<FunctionType const*>(commonType))
{
solAssert(op == Token::Equal || op == Token::NotEqual, "Invalid function pointer comparison!");
solAssert(type->kind() != FunctionType::Kind::External, "External function comparison not allowed!");
}
solAssert(commonType->isValueType(), ""); solAssert(commonType->isValueType(), "");
bool isSigned = false; bool isSigned = false;
if (auto type = dynamic_cast<IntegerType const*>(commonType)) if (auto type = dynamic_cast<IntegerType const*>(commonType))

23
test/libsolidity/semanticTests/viaYul/comparison_functions.sol Normal file
View File

@ -0,0 +1,23 @@
contract C {
function internal1() internal pure returns (bool) {
return true;
}
function internal2() internal pure returns (bool) {
return true;
}
function equal() public pure returns (bool same, bool diff) {
same = internal1 == internal1;
diff = internal1 == internal2;
}
function unequal() public pure returns (bool same, bool diff) {
same = internal1 != internal1;
diff = internal1 != internal2;
}
}
// ====
// compileViaYul: true
// ----
// equal() -> true, false
// unequal() -> false, true