cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #8865 from a3d4/fix-8712-abi-compiler-error

Browse Source 
Fix ABI internal compiler error caused by an internal constructor
This commit is contained in:
chriseth 2020-05-07 10:55:00 +02:00 committed by GitHub
commit 80b4e51fd6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog.md
View File

@ -9,6 +9,7 @@ Compiler Features:
Bugfixes:
* ABI: Skip ``private`` or ``internal`` constructors.

5
libsolidity/interface/ABI.cpp
View File

@ -73,9 +73,10 @@ Json::Value ABI::generate(ContractDefinition const& _contractDef)
);
abi.emplace(std::move(method));
}
if (_contractDef.constructor())
FunctionDefinition const* constructor = _contractDef.constructor();
if (constructor && constructor->visibility() >= Visibility::Public)
{
FunctionType constrType(*_contractDef.constructor());
FunctionType constrType(*constructor);
FunctionType const* externalFunctionType = constrType.interfaceFunctionType();
solAssert(!!externalFunctionType, "");
Json::Value method;

9
test/libsolidity/ABIJson/internal_constructor.sol Normal file
View File

@ -0,0 +1,9 @@
// bug #8712
contract B {
uint immutable x;
constructor(function() internal returns(uint) fp) internal {
x = fp(); }
}
// ----
// :B
// []