cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

AsmAnalyzer: Only perform further analysis when still in success state (to avoid false positives)

Browse Source
This commit is contained in:
Christian Parpart 2019-09-18 12:35:53 +02:00 committed by Christian Parpart
parent a6e34bd441
commit 7fe0f58445
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libyul/AsmAnalysis.cpp
View File

@ -199,7 +199,7 @@ bool AsmAnalyzer::operator()(ExpressionStatement const& _statement)
{
int initialStackHeight = m_stackHeight;
bool success = boost::apply_visitor(*this, _statement.expression);
if (m_stackHeight != initialStackHeight)
if (success && m_stackHeight != initialStackHeight)
{
string msg =
"Top-level expressions are not supposed to return values (this expression returns " +
@ -534,7 +534,7 @@ bool AsmAnalyzer::operator()(Block const& _block)
m_stackHeight -= scope(&_block).numberOfVariables();
int const stackDiff = m_stackHeight - initialStackHeight;
if (stackDiff != 0)
if (success && stackDiff != 0)
{
m_errorReporter.declarationError(
_block.location,
@ -559,7 +559,7 @@ bool AsmAnalyzer::expectExpression(Expression const& _expr)
int const initialHeight = m_stackHeight;
if (!boost::apply_visitor(*this, _expr))
success = false;
if (!expectDeposit(1, initialHeight, locationOf(_expr)))
if (success && !expectDeposit(1, initialHeight, locationOf(_expr)))
success = false;
return success;
}