Merge pull request #10394 from ethereum/viayul-tests

Switch compileViaYul to also where appropriate

test/libsolidity/semanticTests/array/copying/array_copy_clear_storage_packed.sol

@@ -39,7 +39,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // ----
 // f() -> 0
 // g() -> 0

test/libsolidity/semanticTests/constructor_ihneritance_init_order_2.sol

@@ -8,7 +8,7 @@ contract B is A {
     uint public y = f();
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // constructor() ->

test/libsolidity/semanticTests/freeFunctions/free_runtimecode.sol

@@ -12,6 +12,6 @@ contract D {
   }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // ----
 // f() -> true

test/libsolidity/semanticTests/freeFunctions/new_operator.sol

@@ -12,6 +12,6 @@ contract D {
   }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // ----
 // f() -> 2

test/libsolidity/semanticTests/revertStrings/function_entry_checks_v1.sol

@@ -0,0 +1,10 @@
+pragma abicoder v1;
+contract C {
+    function t(uint) public pure {}
+}
+// ====
+// EVMVersion: >=byzantium
+// compileViaYul: false
+// revertStrings: debug
+// ----
+// t(uint256) -> FAILURE, hex"08c379a0", 0x20, 0x12, "Calldata too short"

test/libsolidity/semanticTests/revertStrings/function_entry_checks_v1_abiv2.sol

@@ -0,0 +1,10 @@
+pragma abicoder v2;
+contract C {
+    function t(uint) public pure {}
+}
+// ====
+// EVMVersion: >=byzantium
+// compileViaYul: false
+// revertStrings: debug
+// ----
+// t(uint256) -> FAILURE, hex"08c379a0", 0x20, 34, "ABI decoding: tuple data too sho", "rt"

test/libsolidity/semanticTests/viaYul/array_memory_as_parameter.sol

@@ -18,7 +18,7 @@ contract C {
 	}
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // ----
 // test(uint256,uint256): 0,0 -> FAILURE
 // test(uint256,uint256): 1,0 -> 1

test/libsolidity/semanticTests/viaYul/array_memory_create.sol

@@ -6,7 +6,7 @@ contract C {
 	}
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // ----
 // create(uint256): 0 -> 0
 // create(uint256): 7 -> 7

test/libsolidity/semanticTests/viaYul/array_memory_index_access.sol

@@ -22,7 +22,7 @@ contract C {
 	}
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // ----
 // index(uint256): 0 -> true
 // index(uint256): 10 -> true

test/libsolidity/semanticTests/viaYul/array_storage_index_access.sol

@@ -14,7 +14,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // ----
 // test_indices(uint256): 1 ->
 // test_indices(uint256): 129 ->

test/libsolidity/semanticTests/viaYul/array_storage_index_boundary_test.sol

@@ -10,7 +10,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // ----
 // test_boundary_check(uint256, uint256): 10, 11 -> FAILURE
 // test_boundary_check(uint256, uint256): 10, 9 -> 0

test/libsolidity/semanticTests/viaYul/array_storage_index_zeroed_test.sol

@@ -50,7 +50,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // ----
 // test_zeroed_indicies(uint256): 1 ->
 // test_zeroed_indicies(uint256): 5 ->

test/libsolidity/semanticTests/viaYul/array_storage_length_access.sol

@@ -7,7 +7,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // ----
 // set_get_length(uint256): 0 -> 0
 // set_get_length(uint256): 1 -> 1

test/libsolidity/semanticTests/viaYul/array_storage_pop_zero_length.sol

@@ -6,6 +6,6 @@ contract C {
 }
 // ====
 // EVMVersion: >=petersburg
-// compileViaYul: true
+// compileViaYul: also
 // ----
 // popEmpty() -> FAILURE

test/libsolidity/semanticTests/viaYul/array_storage_push_empty.sol

@@ -9,7 +9,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // EVMVersion: >=petersburg
 // ----
 // pushEmpty(uint256): 128

test/libsolidity/semanticTests/viaYul/array_storage_push_empty_length_address.sol

@@ -10,7 +10,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // EVMVersion: >=petersburg
 // ----
 // set_get_length(uint256): 0 -> 0

test/libsolidity/semanticTests/viaYul/array_storage_push_pop.sol

@@ -9,7 +9,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // ----
 // set_get_length(uint256): 0 -> 0
 // set_get_length(uint256): 1 -> 0

test/libsolidity/semanticTests/viaYul/assert.sol

@@ -14,7 +14,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f(bool): true -> true

test/libsolidity/semanticTests/viaYul/assert_and_require.sol

@@ -11,7 +11,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f(bool): true -> true

test/libsolidity/semanticTests/viaYul/comparison.sol

@@ -37,7 +37,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // ----
 // f(address): 0x1234 -> false
 // f(address): 0x00 -> true

test/libsolidity/semanticTests/viaYul/comparison_functions.sol

@@ -1,9 +1,11 @@
 contract C {
+	// If these two functions are identical, the optimiser
+	// on the old codegen path can deduplicate them, and breaking the test.
 	function internal1() internal pure returns (bool) {
 		return true;
 	}
 	function internal2() internal pure returns (bool) {
-		return true;
+		return false;
 	}
 
 	function equal() public pure returns (bool same, bool diff, bool inv) {
@@ -23,7 +25,7 @@ contract C {
 	}
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // equal() -> true, false, false

test/libsolidity/semanticTests/viaYul/conversion/explicit_cast_assignment.sol

@@ -5,7 +5,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f() -> 0x78

test/libsolidity/semanticTests/viaYul/conversion/explicit_cast_function_call.sol

@@ -7,7 +7,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // g() -> 0x1234567800000000000000000000000000000000000000000000000000000000

test/libsolidity/semanticTests/viaYul/conversion/explicit_cast_local_assignment.sol

@@ -5,7 +5,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f(uint256): 0x12345678 -> 0x78

test/libsolidity/semanticTests/viaYul/conversion/implicit_cast_assignment.sol

@@ -9,7 +9,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f() -> 0x78

test/libsolidity/semanticTests/viaYul/conversion/implicit_cast_function_call.sol

@@ -12,7 +12,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // g() -> 0x78

test/libsolidity/semanticTests/viaYul/conversion/implicit_cast_local_assignment.sol

@@ -8,7 +8,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f() -> 0x78

test/libsolidity/semanticTests/viaYul/delete.sol

@@ -19,7 +19,7 @@ contract C {
 	}
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // call_deleted_internal_func() -> FAILURE

test/libsolidity/semanticTests/viaYul/function_entry_checks.sol

@@ -17,7 +17,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f() -> 0

test/libsolidity/semanticTests/viaYul/if.sol

@@ -60,7 +60,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f(bool): 0 -> 23

test/libsolidity/semanticTests/viaYul/keccak.sol

@@ -8,7 +8,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // ----
 // keccak1() -> 0x64e604787cbf194841e7b68d7cd28786f6c9a0a3ab9f8b0a0e87cb4387ab0107
 // keccak2() -> 0x64e604787cbf194841e7b68d7cd28786f6c9a0a3ab9f8b0a0e87cb4387ab0107

test/libsolidity/semanticTests/viaYul/local_address_assignment.sol

@@ -5,7 +5,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f(address): 0x1234 -> 0x1234

test/libsolidity/semanticTests/viaYul/local_assignment.sol

@@ -5,7 +5,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f(uint256): 6 -> 6

test/libsolidity/semanticTests/viaYul/local_bool_assignment.sol

@@ -5,7 +5,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f(bool): true -> true

test/libsolidity/semanticTests/viaYul/loops/break.sol

@@ -24,7 +24,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f() -> 2

test/libsolidity/semanticTests/viaYul/loops/continue.sol

@@ -30,7 +30,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f() -> 11

test/libsolidity/semanticTests/viaYul/loops/return.sol

@@ -27,7 +27,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f() -> 1

test/libsolidity/semanticTests/viaYul/loops/simple.sol

@@ -30,7 +30,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f() -> 1024

test/libsolidity/semanticTests/viaYul/mapping_string_key.sol

@@ -5,6 +5,6 @@ contract C {
 	}
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // ----
 // set(string): 0x20, 32, "01234567890123456789012345678901" ->

test/libsolidity/semanticTests/viaYul/msg_sender.sol

@@ -6,7 +6,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // test() -> true

test/libsolidity/semanticTests/viaYul/return.sol

@@ -5,7 +5,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f() -> 7

test/libsolidity/semanticTests/viaYul/return_and_convert.sol

@@ -6,7 +6,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f() -> 255

test/libsolidity/semanticTests/viaYul/short_circuit.sol

@@ -9,7 +9,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // or(uint256): 0 -> true, 0

test/libsolidity/semanticTests/viaYul/simple_assignment.sol

@@ -5,7 +5,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f(uint256,uint256): 5, 6 -> 5, 6

test/libsolidity/semanticTests/viaYul/simple_inline_asm.sol

@@ -12,7 +12,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f() -> 6

test/libsolidity/semanticTests/viaYul/smoke_test.sol

@@ -1,7 +1,7 @@
 contract C {
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // allowNonExistingFunctions: true
 // ----

test/libsolidity/semanticTests/viaYul/storage/mappings.sol

@@ -29,7 +29,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // ----
 // test_simple(uint256): 0 -> 3, 4, 5
 // test_simple(uint256): 1 -> 3, 4, 5

test/libsolidity/semanticTests/viaYul/storage/packed_storage.sol

@@ -11,7 +11,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f(uint8): 6 -> 9

test/libsolidity/semanticTests/viaYul/storage/simple_storage.sol

@@ -11,7 +11,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // setX(uint256): 6 -> 6

test/libsolidity/semanticTests/viaYul/string_format.sol

@@ -5,7 +5,7 @@ contract C {
 	function h() external pure returns (bytes4) { return 0xcafecafe; }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f1() -> 0x20, 6, left(0x616263616263)

test/libsolidity/semanticTests/viaYul/string_literals.sol

@@ -19,7 +19,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // short_dyn() -> 0x20, 3, "abc"

test/libsolidity/semanticTests/viaYul/various_inline_asm.sol

@@ -18,7 +18,7 @@ contract C {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f() -> 70

test/libsolidity/semanticTests/viaYul/virtual_functions.sol

@@ -24,7 +24,7 @@ contract C is X {
     }
 }
 // ====
-// compileViaYul: true
+// compileViaYul: also
 // compileToEwasm: also
 // ----
 // f() -> 3