cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #5406 from ethereum/uninitializedStorageUnimplemented

Browse Source 
Ignore unimplemented functions for detecting uninitialized storage returns.
This commit is contained in:
chriseth 2018-11-13 13:22:59 +01:00 committed by GitHub
commit 7e0041cf22
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog.md
View File

@ -111,6 +111,7 @@ Bugfixes:
* Code Generator: Properly handle negative number literals in ABIEncoderV2. * Code Generator: Properly handle negative number literals in ABIEncoderV2.
* Code Generator: Do not crash on using a length of zero for multidimensional fixed-size arrays. * Code Generator: Do not crash on using a length of zero for multidimensional fixed-size arrays.
* Commandline Interface: Correctly handle paths with backslashes on windows. * Commandline Interface: Correctly handle paths with backslashes on windows.
* Control Flow Analyzer: Ignore unimplemented functions when detecting uninitialized storage pointer returns.
* Fix NatSpec json output for `@notice` and `@dev` tags on contract definitions. * Fix NatSpec json output for `@notice` and `@dev` tags on contract definitions.
* Optimizer: Correctly estimate gas costs of constants for special cases. * Optimizer: Correctly estimate gas costs of constants for special cases.
* Optimizer: Fix simplification rule initialization bug that appeared on some emscripten platforms. * Optimizer: Fix simplification rule initialization bug that appeared on some emscripten platforms.

3
libsolidity/analysis/ControlFlowAnalyzer.cpp
View File

@ -28,8 +28,11 @@ bool ControlFlowAnalyzer::analyze(ASTNode const& _astRoot)
bool ControlFlowAnalyzer::visit(FunctionDefinition const& _function) bool ControlFlowAnalyzer::visit(FunctionDefinition const& _function)
{ {
if (_function.isImplemented())
{
auto const& functionFlow = m_cfg.functionFlow(_function); auto const& functionFlow = m_cfg.functionFlow(_function);
checkUnassignedStorageReturnValues(_function, functionFlow.entry, functionFlow.exit); checkUnassignedStorageReturnValues(_function, functionFlow.entry, functionFlow.exit);
}
return false; return false;
} }

4
test/libsolidity/syntaxTests/controlFlow/storageReturn/unimplemented_internal.sol Normal file
View File

@ -0,0 +1,4 @@
contract C {
function f() internal returns(uint[] storage);
function g() internal returns(uint[] storage s);
}

4
test/libsolidity/syntaxTests/controlFlow/storageReturn/unimplemented_library.sol Normal file
View File

@ -0,0 +1,4 @@
library L {
function f() public returns(uint[] storage);
function g() public returns(uint[] storage s);
}