cerc-io/solidity
11
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Re-use knowledge about keccak calls.

Browse Source 
Re-use knowledge about keccak calls.

Update gas cost.

More tests.

Fix bug.

Update libyul/optimiser/DataFlowAnalyzer.cpp

Remove util prefixes

fix test

More test cases.

Add Changelog entry
This commit is contained in:
chriseth
2022-12-07 14:16:13 +01:00
committed by Nikola Matic
parent 591df04211
commit 79c52b3c9e
14 changed files with 257 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/libsolidity/semanticTests/array/reusing_memory.sol
+1 -1
View File
@@ -24,6 +24,6 @@ contract Main {
}
// ----
// f(uint256): 0x34 -> 0x46bddb1178e94d7f2892ff5f366840eb658911794f2c3a44c450aa2c505186c1
// gas irOptimized: 112899
// gas irOptimized: 112757
// gas legacy: 126596
// gas legacyOptimized: 113823
test/libsolidity/semanticTests/structs/copy_substructures_to_mapping.sol
+3 -3
View File
@@ -53,14 +53,14 @@ contract C {
// ----
// from_memory() -> 0x20, 0x60, 0xa0, 0x15, 3, 0x666F6F0000000000000000000000000000000000000000000000000000000000, 2, 13, 14
// gas irOptimized: 123062
// gas irOptimized: 123041
// gas legacy: 130289
// gas legacyOptimized: 128785
// from_state() -> 0x20, 0x60, 0xa0, 21, 3, 0x666F6F0000000000000000000000000000000000000000000000000000000000, 2, 13, 14
// gas irOptimized: 121776
// gas irOptimized: 121737
// gas legacy: 123341
// gas legacyOptimized: 121892
// from_calldata((bytes,uint16[],uint16)): 0x20, 0x60, 0xa0, 21, 3, 0x666F6F0000000000000000000000000000000000000000000000000000000000, 2, 13, 14 -> 0x20, 0x60, 0xa0, 0x15, 3, 0x666F6F0000000000000000000000000000000000000000000000000000000000, 2, 13, 14
// gas irOptimized: 115169
// gas irOptimized: 115127
// gas legacy: 122579
// gas legacyOptimized: 120829
test/libsolidity/semanticTests/structs/struct_copy.sol
+1 -1
View File
@@ -36,7 +36,7 @@ contract c {
// ----
// set(uint256): 7 -> true
// gas irOptimized: 110032
// gas irOptimized: 109897
// gas legacy: 110616
// gas legacyOptimized: 110006
// retrieve(uint256): 7 -> 1, 3, 4, 2
test/libyul/yulOptimizerTests/loadResolver/keccak_reuse_basic.yul
+19
View File
@@ -0,0 +1,19 @@
{
let x := calldataload(0)
let a := keccak256(0, x)
sstore(a, 2)
let t := mload(2)
let b := keccak256(0, x)
sstore(b, 3)
}
// ----
// step: loadResolver
//
// {
// {
// let _1 := 0
// let a := keccak256(_1, calldataload(_1))
// sstore(a, 2)
// sstore(a, 3)
// }
// }
test/libyul/yulOptimizerTests/loadResolver/keccak_reuse_expr_mstore.yul
+30
View File
@@ -0,0 +1,30 @@
{
let a := calldataload(0)
sstore(f(keccak256(0, a)), keccak256(0, a))
sstore(f(keccak256(0, a)), keccak256(0, a))
sstore(keccak256(0, a), f(keccak256(0, a)))
function f(x) -> y {
mstore(x, 2)
y := mload(8)
}
}
// ----
// step: loadResolver
//
// {
// {
// let _1 := 0
// let a := calldataload(_1)
// let _3 := keccak256(_1, a)
// sstore(f(_3), _3)
// let _8 := keccak256(_1, a)
// sstore(f(_8), _8)
// sstore(keccak256(_1, a), f(keccak256(_1, a)))
// }
// function f(x) -> y
// {
// mstore(x, 2)
// y := mload(8)
// }
// }
test/libyul/yulOptimizerTests/loadResolver/keccak_reuse_in_expression.yul
+14
View File
@@ -0,0 +1,14 @@
{
let x := calldataload(0)
sstore(keccak256(0, x), keccak256(0, x))
}
// ----
// step: loadResolver
//
// {
// {
// let _1 := 0
// let _3 := keccak256(_1, calldataload(_1))
// sstore(_3, _3)
// }
// }
test/libyul/yulOptimizerTests/loadResolver/keccak_reuse_msize.yul
+18
View File
@@ -0,0 +1,18 @@
{
let a := calldataload(0)
let t := msize()
let x := keccak256(0, a)
let y := keccak256(0, a)
sstore(x, y)
}
// ----
// step: loadResolver
//
// {
// {
// let _1 := 0
// let a := calldataload(_1)
// let x := keccak256(_1, a)
// sstore(x, keccak256(_1, a))
// }
// }
test/libyul/yulOptimizerTests/loadResolver/keccak_reuse_mstore.yul
+22
View File
@@ -0,0 +1,22 @@
{
let x := calldataload(0)
let a := keccak256(0x20, x)
sstore(a, 2)
// will disable loading for now, might improve later
mstore(0, 1)
let b := keccak256(0x20, x)
sstore(b, 3)
}
// ----
// step: loadResolver
//
// {
// {
// let _1 := 0
// let x := calldataload(_1)
// let _2 := 0x20
// sstore(keccak256(_2, x), 2)
// mstore(_1, 1)
// sstore(keccak256(_2, x), 3)
// }
// }
test/libyul/yulOptimizerTests/loadResolver/keccak_reuse_reassigned_branch.yul
+37
View File
@@ -0,0 +1,37 @@
{
let x := calldataload(0)
let y := calldataload(1)
let a := keccak256(x, y)
if calldataload(2) {
a := 8
}
let b := keccak256(x, y)
sstore(b, 2)
if calldataload(3) {
x := 8
}
let c := keccak256(x, y)
sstore(c, 2)
if calldataload(4) {
y := 8
}
let d := keccak256(x, y)
sstore(d, 2)
}
// ----
// step: loadResolver
//
// {
// {
// let x := calldataload(0)
// let y := calldataload(1)
// let a := keccak256(x, y)
// let _3 := 2
// if calldataload(_3) { a := 8 }
// sstore(keccak256(x, y), _3)
// if calldataload(3) { x := 8 }
// sstore(keccak256(x, y), _3)
// if calldataload(4) { y := 8 }
// sstore(keccak256(x, y), _3)
// }
// }
test/libyul/yulOptimizerTests/loadResolver/keccak_reuse_reassigned_value.yul
+41
View File
@@ -0,0 +1,41 @@
{
let x := calldataload(0)
let y := calldataload(1)
let a := keccak256(x, y)
sstore(a, 2)
// reassign value
a := calldataload(10)
let b := keccak256(x, y)
sstore(b, 3)
// reassign arg1
x := 10
let c := keccak256(x, y)
sstore(c, 4)
// reassign arg2
y := 9
let d := keccak256(x, y)
sstore(d, 5)
// no reassign, check that it is still working here.
let e := keccak256(x, y)
sstore(e, 6)
}
// ----
// step: loadResolver
//
// {
// {
// let x := calldataload(0)
// let y := calldataload(1)
// let a := keccak256(x, y)
// sstore(a, 2)
// let _4 := 10
// a := calldataload(_4)
// sstore(keccak256(x, y), 3)
// x := _4
// sstore(keccak256(_4, y), 4)
// y := 9
// let d := keccak256(_4, y)
// sstore(d, 5)
// sstore(d, 6)
// }
// }