cerc-io/solidity
11
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Properly validate invalid hex characters in JSONIO libraries

Browse Source
This commit is contained in:
Alex Beregszaszi
2018-02-28 10:44:48 +01:00
parent 83fec0232d
commit 7897301b71
2 changed files with 37 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libsolidity/interface/StandardCompiler.cpp
+14 -2
View File
@@ -336,8 +336,20 @@ Json::Value StandardCompiler::compileInternal(Json::Value const& _input)
if (!jsonSourceName.isObject())
return formatFatalError("JSONError", "library entry is not a JSON object.");
for (auto const& library: jsonSourceName.getMemberNames())
// @TODO use libraries only for the given source
libraries[library] = h160(jsonSourceName[library].asString());
{
try
{
// @TODO use libraries only for the given source
libraries[library] = h160(jsonSourceName[library].asString());
}
catch (dev::BadHexCharacter)
{
return formatFatalError(
"JSONError",
"Invalid library address (\"" + jsonSourceName[library].asString() + "\") supplied."
);
}
}
}
m_compilerStack.setLibraries(libraries);