Added invocation of base class addOptions in derived to populate list with common and derived options, fixed errors with editor member variable type mismatch

This commit is contained in:
Sean Hawkes 2021-09-18 06:22:27 -05:00
parent ae7c617711
commit 76fa00abed
2 changed files with 4 additions and 3 deletions

View File

@ -67,8 +67,9 @@ IsolTestOptions::IsolTestOptions(std::string* _editor):
void IsolTestOptions::addOptions() void IsolTestOptions::addOptions()
{ {
CommonOptions::addOptions();
options.add_options() options.add_options()
("editor", po::value<std::string>(_editor)->default_value(editorPath()), "Path to editor for opening test files.") ("editor", po::value<std::string>(editor)->default_value(editorPath()), "Path to editor for opening test files.")
("help", po::bool_switch(&showHelp), "Show this help screen.") ("help", po::bool_switch(&showHelp), "Show this help screen.")
("no-color", po::bool_switch(&noColor), "Don't use colors.") ("no-color", po::bool_switch(&noColor), "Don't use colors.")
("accept-updates", po::bool_switch(&acceptUpdates), "Automatically accept expectation updates.") ("accept-updates", po::bool_switch(&acceptUpdates), "Automatically accept expectation updates.")

View File

@ -33,9 +33,9 @@ struct IsolTestOptions: CommonOptions
bool noColor = false; bool noColor = false;
bool acceptUpdates = false; bool acceptUpdates = false;
std::string testFilter = std::string{}; std::string testFilter = std::string{};
std::string editor = std::string{}; std::string* editor = nullptr;
explicit IsolTestOptions(const std::string* _editor); explicit IsolTestOptions(std::string* _editor);
void addOptions() override; void addOptions() override;
bool parse(int _argc, char const* const* _argv) override; bool parse(int _argc, char const* const* _argv) override;
void validate() const override; void validate() const override;