cerc-io/solidity
11
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #2450 from ethereum/addressstring

Browse Source 
Fix for strings treated as addresses.
This commit is contained in:
Alex Beregszaszi
2017-06-26 12:18:33 +01:00
committed by GitHub
parent a0b0df2d98 c33d818a68
commit 751ba701bc
3 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/libsolidity/SolidityNameAndTypeResolution.cpp
+19
View File
@@ -5487,6 +5487,25 @@ BOOST_AUTO_TEST_CASE(invalid_address_length)
CHECK_WARNING(text, "checksum");
}
BOOST_AUTO_TEST_CASE(address_test_for_bug_in_implementation)
{
// A previous implementation claimed the string would be an address
char const* text = R"(
contract AddrString {
address public test = "0xCA35b7d915458EF540aDe6068dFe2F44E8fa733c";
}
)";
CHECK_ERROR(text, TypeError, "is not implicitly convertible to expected type address");
text = R"(
contract AddrString {
function f() returns (address) {
return "0xCA35b7d915458EF540aDe6068dFe2F44E8fa733c";
}
}
)";
CHECK_ERROR(text, TypeError, "is not implicitly convertible to expected type");
}
BOOST_AUTO_TEST_CASE(early_exit_on_fatal_errors)
{
// This tests a crash that occured because we did not stop for fatal errors.