Merge pull request #8630 from ethereum/encoding-bug-functionCallOption

TypeChecker error when encoding functions with call options; tests
This commit is contained in:
chriseth
2020-04-08 16:33:24 +02:00
committed by GitHub
4 changed files with 17 additions and 4 deletions
@@ -0,0 +1,11 @@
contract C {
function f() public payable {
abi.encode(this.f{value: 2});
abi.encode(this.f{gas: 2});
abi.encode(this.f{value: 2, gas: 1});
}
}
// ----
// TypeError: (60-76): This type cannot be encoded.
// TypeError: (92-106): This type cannot be encoded.
// TypeError: (122-146): This type cannot be encoded.
@@ -1,12 +1,11 @@
contract C {
function f() public pure {
bytes32 h = keccak256(abi.encodePacked(keccak256, f, this.f.gas, blockhash));
bytes32 h = keccak256(abi.encodePacked(keccak256, f, this.f{gas: 2}, blockhash));
h;
}
}
// ----
// Warning: (105-115): Using ".gas(...)" is deprecated. Use "{gas: ...}" instead.
// TypeError: (91-100): This type cannot be encoded.
// TypeError: (102-103): This type cannot be encoded.
// TypeError: (105-115): This type cannot be encoded.
// TypeError: (117-126): This type cannot be encoded.
// TypeError: (105-119): This type cannot be encoded.
// TypeError: (121-130): This type cannot be encoded.