cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Warn on YUL switch statement with only default statement

Browse Source
This commit is contained in:
Harikrishnan Mulackal 2020-05-13 20:43:05 +05:30 committed by chriseth
parent ecaedebe53
commit 73e634924e
3 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libyul/AsmAnalysis.cpp
View File

@ -359,6 +359,13 @@ void AsmAnalyzer::operator()(Switch const& _switch)
{ {
yulAssert(_switch.expression, ""); yulAssert(_switch.expression, "");
if (_switch.cases.size() == 1 && !_switch.cases[0].value)
m_errorReporter.warning(
1878_error,
_switch.location,
"\"switch\" statement with only a default case."
);
YulString valueType = expectExpression(*_switch.expression); YulString valueType = expectExpression(*_switch.expression);
set<u256> cases; set<u256> cases;

1
test/libsolidity/syntaxTests/controlFlow/localStorageVariables/assembly/switch_declaration_fine.sol
View File

@ -29,3 +29,4 @@ contract C {
} }
} }
// ---- // ----
// Warning: (141-190): "switch" statement with only a default case.

1
test/libsolidity/syntaxTests/controlFlow/storageReturn/assembly/switch_fine.sol
View File

@ -23,3 +23,4 @@ contract C {
} }
} }
// ---- // ----
// Warning: (142-191): "switch" statement with only a default case.