cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Abort early if there is nothing to encode or decode.

Browse Source
This commit is contained in:
chriseth 2017-06-30 14:09:35 +02:00
parent 735c977db1
commit 71d866cd7a
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libsolidity/codegen/CompilerUtils.cpp
View File

@ -180,6 +180,9 @@ void CompilerUtils::encodeToMemory(
t = t->mobileType()->interfaceType(_encodeAsLibraryTypes)->encodingType(); t = t->mobileType()->interfaceType(_encodeAsLibraryTypes)->encodingType();
} }
if (_givenTypes.empty())
return;
// Stack during operation: // Stack during operation:
// <v1> <v2> ... <vn> <mem_start> <dyn_head_1> ... <dyn_head_r> <end_of_mem> // <v1> <v2> ... <vn> <mem_start> <dyn_head_1> ... <dyn_head_r> <end_of_mem>
// The values dyn_head_i are added during the first loop and they point to the head part // The values dyn_head_i are added during the first loop and they point to the head part

3
libsolidity/codegen/ContractCompiler.cpp
View File

@ -299,9 +299,12 @@ void ContractCompiler::appendFunctionSelector(ContractDefinition const& _contrac
// Return tag is used to jump out of the function. // Return tag is used to jump out of the function.
eth::AssemblyItem returnTag = m_context.pushNewTag(); eth::AssemblyItem returnTag = m_context.pushNewTag();
if (!functionType->parameterTypes().empty())
{
// Parameter for calldataUnpacker // Parameter for calldataUnpacker
m_context << CompilerUtils::dataStartOffset; m_context << CompilerUtils::dataStartOffset;
appendCalldataUnpacker(functionType->parameterTypes()); appendCalldataUnpacker(functionType->parameterTypes());
}
m_context.appendJumpTo(m_context.functionEntryLabel(functionType->declaration())); m_context.appendJumpTo(m_context.functionEntryLabel(functionType->declaration()));
m_context << returnTag; m_context << returnTag;
// Return tag and input parameters get consumed. // Return tag and input parameters get consumed.