cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #10910 from ethereum/calldataLValueSol2Yul

Browse Source 
[Sol->Yul] Fixing setLValue for calldata types.
This commit is contained in:
chriseth 2021-02-08 13:17:58 +01:00 committed by GitHub
commit 711671236a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libsolidity/codegen/ir/IRGeneratorForStatements.cpp
View File

@ -2918,10 +2918,7 @@ void IRGeneratorForStatements::setLValue(Expression const& _expression, IRLValue
solAssert(!m_currentLValue, ""); solAssert(!m_currentLValue, "");
if (_expression.annotation().willBeWrittenTo) if (_expression.annotation().willBeWrittenTo)
{
m_currentLValue.emplace(std::move(_lvalue)); m_currentLValue.emplace(std::move(_lvalue));
solAssert(!_lvalue.type.dataStoredIn(DataLocation::CallData), "");
}
else else
// Only define the expression, if it will not be written to. // Only define the expression, if it will not be written to.
define(_expression, readFromLValue(_lvalue)); define(_expression, readFromLValue(_lvalue));

10
test/libsolidity/semanticTests/array/slices/array_calldata_assignment.sol Normal file
View File

@ -0,0 +1,10 @@
contract C {
function f(uint256[] calldata x, uint256[] calldata y, uint256 i) external returns (uint256) {
x = y;
return x[i];
}
}
// ====
// compileViaYul: also
// ----
// f(uint256[], uint256[], uint256): 0x60, 0xA0, 1, 1, 0, 2, 1, 2 -> 2