cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #2551 from ethereum/fixStructMemberWarning

Browse Source 
Fix invalid "explicit storage keyword" warning for reference members of structs.
This commit is contained in:
Alex Beregszaszi 2017-07-10 19:31:09 +02:00 committed by GitHub
commit 6fa5d47f8f
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog.md
View File

@ -3,6 +3,7 @@
Features:
Bugfixes:
* Type Checker: Fix invalid "specify storage keyword" warning for reference members of structs.
### 0.4.13 (2017-07-06)

2
libsolidity/analysis/ReferencesResolver.cpp
View File

@ -295,7 +295,7 @@ void ReferencesResolver::endVisit(VariableDeclaration const& _variable)
else
{
typeLoc = DataLocation::Storage;
if (!_variable.isStateVariable())
if (_variable.isLocalVariable())
m_errorReporter.warning(
_variable.location(),
"Variable is declared as a storage pointer. "

2
test/libsolidity/SolidityNameAndTypeResolution.cpp
View File

@ -6160,7 +6160,7 @@ BOOST_AUTO_TEST_CASE(warn_unspecified_storage)
{
char const* text = R"(
contract C {
struct S { uint a; }
struct S { uint a; string b; }
S x;
function f() {
S storage y = x;