cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove a dedicated error flag from ReferencesResolver

Browse Source
This commit is contained in:
a3d4 2020-05-12 23:23:01 +02:00
parent d7b434fc6b
commit 6dbf23d52a
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libsolidity/analysis/ReferencesResolver.cpp
View File

@ -44,8 +44,9 @@ namespace solidity::frontend
bool ReferencesResolver::resolve(ASTNode const& _root) bool ReferencesResolver::resolve(ASTNode const& _root)
{ {
auto errorWatcher = m_errorReporter.errorWatcher();
_root.accept(*this); _root.accept(*this);
return !m_errorOccurred; return errorWatcher.ok();
} }
bool ReferencesResolver::visit(Block const& _block) bool ReferencesResolver::visit(Block const& _block)
@ -267,19 +268,16 @@ void ReferencesResolver::operator()(yul::VariableDeclaration const& _varDecl)
void ReferencesResolver::declarationError(SourceLocation const& _location, string const& _description) void ReferencesResolver::declarationError(SourceLocation const& _location, string const& _description)
{ {
m_errorOccurred = true;
m_errorReporter.declarationError(8532_error, _location, _description); m_errorReporter.declarationError(8532_error, _location, _description);
} }
void ReferencesResolver::declarationError(SourceLocation const& _location, SecondarySourceLocation const& _ssl, string const& _description) void ReferencesResolver::declarationError(SourceLocation const& _location, SecondarySourceLocation const& _ssl, string const& _description)
{ {
m_errorOccurred = true;
m_errorReporter.declarationError(3881_error, _location, _ssl, _description); m_errorReporter.declarationError(3881_error, _location, _ssl, _description);
} }
void ReferencesResolver::fatalDeclarationError(SourceLocation const& _location, string const& _description) void ReferencesResolver::fatalDeclarationError(SourceLocation const& _location, string const& _description)
{ {
m_errorOccurred = true;
m_errorReporter.fatalDeclarationError(6546_error, _location, _description); m_errorReporter.fatalDeclarationError(6546_error, _location, _description);
} }

1
libsolidity/analysis/ReferencesResolver.h
View File

@ -103,7 +103,6 @@ private:
/// Stack of return parameters. /// Stack of return parameters.
std::vector<ParameterList const*> m_returnParameters; std::vector<ParameterList const*> m_returnParameters;
bool const m_resolveInsideCode; bool const m_resolveInsideCode;
bool m_errorOccurred = false;
InlineAssemblyAnnotation* m_yulAnnotation = nullptr; InlineAssemblyAnnotation* m_yulAnnotation = nullptr;
bool m_yulInsideFunction = false; bool m_yulInsideFunction = false;