cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #1778 from ethereum/warnsendtransfer

Browse Source 
Mention 'transfer' in warning about unchecked 'send'.
This commit is contained in:
chriseth 2017-03-15 11:41:40 +01:00 committed by GitHub
commit 6258fe7185
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libsolidity/analysis/TypeChecker.cpp
View File

@ -891,10 +891,11 @@ void TypeChecker::endVisit(ExpressionStatement const& _statement)
if ( if (
location == Location::Bare || location == Location::Bare ||
location == Location::BareCallCode || location == Location::BareCallCode ||
location == Location::BareDelegateCall || location == Location::BareDelegateCall
location == Location::Send
) )
warning(_statement.location(), "Return value of low-level calls not used."); warning(_statement.location(), "Return value of low-level calls not used.");
else if (location == Location::Send)
warning(_statement.location(), "Failure condition of 'send' ignored. Consider using 'transfer' instead.");
} }
} }
} }

2
test/libsolidity/SolidityNameAndTypeResolution.cpp
View File

@ -4420,7 +4420,7 @@ BOOST_AUTO_TEST_CASE(unused_return_value_send)
} }
} }
)"; )";
CHECK_WARNING(text, "Return value of low-level calls not used"); CHECK_WARNING(text, "Failure condition of 'send' ignored. Consider using 'transfer' instead.");
} }
BOOST_AUTO_TEST_CASE(unused_return_value_call) BOOST_AUTO_TEST_CASE(unused_return_value_call)