cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Error messages from abi encodecall are giving more details about the types of the involved variables

Browse Source
This commit is contained in:
nishant-sachdeva 2022-03-11 14:13:42 +05:30
parent 4263b893a3
commit 624d2d3968
6 changed files with 52 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libsolidity/analysis/TypeChecker.cpp
View File

@ -2204,9 +2204,9 @@ void TypeChecker::typeCheckABIEncodeCallFunction(FunctionCall const& _functionCa
"Cannot implicitly convert component at position " + "Cannot implicitly convert component at position " +
to_string(i) + to_string(i) +
" from \"" + " from \"" +
argType.canonicalName() + argType.toString() +
"\" to \"" + "\" to \"" +
functionPointerType->parameterTypes()[i]->canonicalName() + functionPointerType->parameterTypes()[i]->toString() +
"\"" + "\"" +
(result.message().empty() ? "." : ": " + result.message()) (result.message().empty() ? "." : ": " + result.message())
); );

11
test/libsolidity/syntaxTests/abiEncoder/abi_encode_convert_address_to_address_payable.sol Normal file
View File

@ -0,0 +1,11 @@
interface I {
function f(address payable) external;
}
contract C {
function main() external view {
abi.encodeCall(I.f, (address(0)));
}
}
// ----
// TypeError 5407: (136-148): Cannot implicitly convert component at position 0 from "address" to "address payable".

13
test/libsolidity/syntaxTests/abiEncoder/abi_encode_convert_function_pointer_to_different_function_pointer.sol Normal file
View File

@ -0,0 +1,13 @@
interface I {
function f(function (string calldata) external) external;
}
contract C {
function g(string calldata) external {}
function main() external view {
abi.encodeCall(I.f, (this.g));
}
}
// ----
// TypeError 5407: (201-209): Cannot implicitly convert component at position 0 from "function (string memory) external" to "function (string calldata) external".

13
test/libsolidity/syntaxTests/abiEncoder/abi_encode_convert_function_to_different_function.sol Normal file
View File

@ -0,0 +1,13 @@
interface I {
function f(function (string calldata) external view returns (uint)) external;
}
contract C {
function g(string memory) external {}
function main() external view {
abi.encodeCall(I.f, (this.g));
}
}
// ----
// TypeError 5407: (219-227): Cannot implicitly convert component at position 0 from "function (string memory) external" to "function (string calldata) view external returns (uint256)".

12
test/libsolidity/syntaxTests/abiEncoder/abi_encode_convert_string_to_different_string.sol Normal file
View File

@ -0,0 +1,12 @@
interface I {
function f(string calldata) external;
}
contract C {
string s;
function main() external view {
abi.encodeCall(I.f, (s));
}
}
// ----
// TypeError 5407: (150-153): Cannot implicitly convert component at position 0 from "string storage ref" to "string calldata".

2
test/libsolidity/syntaxTests/specialFunctions/encodeCall_fail_args.sol
View File

@ -24,4 +24,4 @@ contract C {
// TypeError 7788: (382-408): Expected 1 instead of 0 components for the tuple parameter. // TypeError 7788: (382-408): Expected 1 instead of 0 components for the tuple parameter.
// TypeError 6219: (489-511): Expected two arguments: a function pointer followed by a tuple. // TypeError 6219: (489-511): Expected two arguments: a function pointer followed by a tuple.
// TypeError 7515: (597-628): Expected a tuple with 2 components instead of a single non-tuple parameter. // TypeError 7515: (597-628): Expected a tuple with 2 components instead of a single non-tuple parameter.
// TypeError 5407: (621-627): Cannot implicitly convert component at position 0 from "uint8[2]" to "int256". // TypeError 5407: (621-627): Cannot implicitly convert component at position 0 from "uint8[2] memory" to "int256".