Merge pull request #4556 from ethereum/library-data-locations

Add tests for data locations within libraries

test/libsolidity/syntaxTests/dataLocations/libraryExternalFunction/function_argument_location_specifier_test_external_calldata.sol

@@ -0,0 +1,3 @@
+library test {
+    function f(bytes calldata) external;
+}

test/libsolidity/syntaxTests/dataLocations/libraryExternalFunction/function_argument_location_specifier_test_external_memory.sol

@@ -0,0 +1,5 @@
+library test {
+    function f(bytes memory) external;
+}
+// ----
+// TypeError: (30-35): Location has to be calldata or storage for external library functions (remove the "memory" keyword).

test/libsolidity/syntaxTests/dataLocations/libraryExternalFunction/function_argument_location_specifier_test_external_storage.sol

@@ -0,0 +1,3 @@
+library test {
+    function f(bytes storage) external;
+}

test/libsolidity/syntaxTests/dataLocations/libraryInternalFunction/function_argument_location_specifier_test_internal_calldata.sol

@@ -0,0 +1,5 @@
+library test {
+    function f(bytes calldata) internal pure {}
+}
+// ----
+// TypeError: (30-35): Variable cannot be declared as "calldata" (remove the "calldata" keyword).

test/libsolidity/syntaxTests/dataLocations/libraryInternalFunction/function_argument_location_specifier_test_internal_memory.sol

@@ -0,0 +1,3 @@
+library test {
+    function f(bytes memory) internal pure {}
+}

test/libsolidity/syntaxTests/dataLocations/libraryInternalFunction/function_argument_location_specifier_test_internal_storage.sol

@@ -0,0 +1,3 @@
+library test {
+    function f(bytes storage) internal pure {}
+}