cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix withdrawal pattern documentation

Browse Source
This commit is contained in:
Denton Liu 2016-07-11 10:28:20 -04:00
parent 82365f21c0
commit 617daa1f00
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
docs/common-patterns.rst
View File

@ -11,8 +11,8 @@ Withdrawal from Contracts
************************* *************************
The recommended method of sending funds after an effect The recommended method of sending funds after an effect
is with the withdrawal pattern. Although the most intuitive is using the withdrawal pattern. Although the most intuitive
aethod of sending Ether as a result of an effect is a method of sending Ether, as a result of an effect, is a
direct ``send`` call, this is not recommended as it direct ``send`` call, this is not recommended as it
introduces a potential security risk. You may read introduces a potential security risk. You may read
more about this on the :ref:`security_considerations` page. more about this on the :ref:`security_considerations` page.
@ -28,7 +28,7 @@ an Ether storage contract.
mapping (address => uint) pendingReturns; mapping (address => uint) pendingReturns;
function sendEther(uint amount) { function sendEther(uint amount) {
if (amount < etherStore[msg.sender]) { if (amount > etherStore[msg.sender]) {
throw; throw;
} }
etherStore[msg.sender] -= amount; etherStore[msg.sender] -= amount;
@ -60,7 +60,7 @@ This is as opposed to the more intuitive sending pattern.
mapping (address => uint) etherStore; mapping (address => uint) etherStore;
function sendEther(uint amount) { function sendEther(uint amount) {
if (amount < etherStore[msg.sender]) { if (amount > etherStore[msg.sender]) {
throw; throw;
} }
etherStore[msg.sender] -= amount; etherStore[msg.sender] -= amount;