cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Stop allow_guessing for command line option parser

Browse Source
This commit is contained in:
Zhen Zhang 2018-02-27 12:31:09 +08:00
parent 1f5eb4ba59
commit 5fd9ea4b2a
3 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog.md
View File

@ -14,6 +14,7 @@ Bugfixes:
* Standalone Assembly: Do not ignore input after closing brace of top level block. * Standalone Assembly: Do not ignore input after closing brace of top level block.
* Standard JSON: catch errors properly when invalid "sources" are passed * Standard JSON: catch errors properly when invalid "sources" are passed
* Type Checker: Properly warn when using ``_offset`` and ``_slot`` for constants in inline assembly. * Type Checker: Properly warn when using ``_offset`` and ``_slot`` for constants in inline assembly.
* Commandline interface: throw error if option is unknown
### 0.4.20 (2018-02-14) ### 0.4.20 (2018-02-14)

1
solc/CommandLineInterface.cpp
View File

@ -627,6 +627,7 @@ Allowed options)",
try try
{ {
po::command_line_parser cmdLineParser(_argc, _argv); po::command_line_parser cmdLineParser(_argc, _argv);
cmdLineParser.style(po::command_line_style::default_style & (~po::command_line_style::allow_guessing));
cmdLineParser.options(allOptions).positional(filesPositions); cmdLineParser.options(allOptions).positional(filesPositions);
po::store(cmdLineParser.run(), m_args); po::store(cmdLineParser.run(), m_args);
} }

15
test/cmdlineTests.sh
View File

@ -83,6 +83,21 @@ function compileWithoutWarning()
test -z "$output" -a "$failed" -eq 0 test -z "$output" -a "$failed" -eq 0
} }
printTask "Testing unknown options..."
(
set +e
output=$("$SOLC" --allow=test 2>&1)
failed=$?
set -e
if [ "$output" == "unrecognised option '--allow=test'" ] && [ $failed -ne 0 ] ; then
echo "Passed"
else
printError "Incorrect response to unknown options: $STDERR"
exit 1
fi
)
printTask "Compiling various other contracts and libraries..." printTask "Compiling various other contracts and libraries..."
( (
cd "$REPO_ROOT"/test/compilationTests/ cd "$REPO_ROOT"/test/compilationTests/