cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add comment.

Browse Source
This commit is contained in:
Daniel Kirchner 2023-08-22 18:23:16 +02:00 committed by Nikola Matic
parent fadba0e4b8
commit 5f894722df
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libsolidity/experimental/analysis/TypeInference.cpp
View File

@ -1118,7 +1118,12 @@ void TypeInference::unify(Type _a, Type _b, langutil::SourceLocation _location)
if (!m_activeInstantiations.empty()) if (!m_activeInstantiations.empty())
{ {
// Attempt to resolve interdependencies between type class instantiations. // TODO: This entire logic is superfluous - I thought mutually recursive dependencies between
// class instantiations are a problem, but in fact they're not, they just resolve to mutually recursive
// functions that are fine. So instead, all instantiations can be registered with the type system directly
// when visiting the type class (assuming that they all work out) - and then all instantiations can be checked
// individually, which should still catch all actual issues (while allowing recursions).
// Original comment: Attempt to resolve interdependencies between type class instantiations.
std::vector<TypeClassInstantiation const*> missingInstantiations; std::vector<TypeClassInstantiation const*> missingInstantiations;
bool recursion = false; bool recursion = false;
bool onlyMissingInstantiations = [&]() { bool onlyMissingInstantiations = [&]() {