cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

some notes

Browse Source
This commit is contained in:
chriseth 2022-04-27 15:24:47 +02:00
parent 1a244e7a20
commit 591cb938bc
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libyul/optimiser/ReasoningBasedSimplifier.cpp
View File

@ -131,7 +131,7 @@ void ReasoningBasedSimplifier::operator()(ForLoop& _for)
} }
ASTModifier::operator()(_for.body); ASTModifier::operator()(_for.body);
// TODO clear modified variables! // TODO clear modified variables! - but only if there is a 'break'
ASTModifier::operator()(_for.post); ASTModifier::operator()(_for.post);
// clear variables assigned inside body and post // clear variables assigned inside body and post
@ -148,6 +148,14 @@ void ReasoningBasedSimplifier::operator()(ForLoop& _for)
void ReasoningBasedSimplifier::operator()(FunctionCall& _fun) void ReasoningBasedSimplifier::operator()(FunctionCall& _fun)
{ {
// TODO in general, a big problem is that all expressions involving
// literals have to be evaluated (expression simplifier)
// and rematerialized (literal rematerializer)
// otherwise, the mult by constant does not work.
ASTModifier::operator()(_fun); ASTModifier::operator()(_fun);
// TODO do not forget to add path condition! // TODO do not forget to add path condition!
// TODO and(x, 0xfff) -> x if x <= 0xfff // TODO and(x, 0xfff) -> x if x <= 0xfff