cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

codegen: clean any data from the input

Browse Source
This commit is contained in:
Yoichi Hirai 2016-11-24 11:57:28 +01:00
parent 7959ee49be
commit 547deec4be
No known key found for this signature in database
GPG Key ID: E7B75D080FCF7992
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/miscellaneous.rst
View File

@ -111,6 +111,9 @@ value is considered ``true`` by ``JUMPI`` instruction, we do not clean
the boolean values before they are used as the condition for the boolean values before they are used as the condition for
``JUMPI``. ``JUMPI``.
In addition to the design principle above, the Solidity compiler
cleans input data when it is loaded onto the stack.
Different types have different rules for cleaning up overflows: Different types have different rules for cleaning up overflows:
+---------------+---------------+------------------+ +---------------+---------------+------------------+

4
libsolidity/codegen/CompilerUtils.cpp
View File

@ -925,8 +925,8 @@ unsigned CompilerUtils::loadFromMemoryHelper(Type const& _type, bool _fromCallda
if (leftAligned) if (leftAligned)
m_context << shiftFactor << Instruction::MUL; m_context << shiftFactor << Instruction::MUL;
} }
if (_fromCalldata && _type.category() == Type::Category::Bool) if (_fromCalldata)
m_context << Instruction::ISZERO << Instruction::ISZERO; convertType(_type, _type, true);
return numBytes; return numBytes;
} }

2
test/libsolidity/Assembly.cpp
View File

@ -116,7 +116,7 @@ BOOST_AUTO_TEST_CASE(location_test)
shared_ptr<string const> n = make_shared<string>(""); shared_ptr<string const> n = make_shared<string>("");
AssemblyItems items = compileContract(sourceCode); AssemblyItems items = compileContract(sourceCode);
vector<SourceLocation> locations = vector<SourceLocation> locations =
vector<SourceLocation>(16, SourceLocation(2, 75, n)) + vector<SourceLocation>(18, SourceLocation(2, 75, n)) +
vector<SourceLocation>(27, SourceLocation(20, 72, n)) + vector<SourceLocation>(27, SourceLocation(20, 72, n)) +
vector<SourceLocation>{SourceLocation(42, 51, n), SourceLocation(65, 67, n)} + vector<SourceLocation>{SourceLocation(42, 51, n), SourceLocation(65, 67, n)} +
vector<SourceLocation>(2, SourceLocation(58, 67, n)) + vector<SourceLocation>(2, SourceLocation(58, 67, n)) +