cerc-io/solidity
11
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

prepare_report: Handle internal compiler errors in Standard JSON as errors, not missing bytecode

Browse Source
This commit is contained in:
Kamil Śliwak
2021-01-26 23:30:38 +01:00
parent f7007ea324
commit 53f9a11440
9 changed files with 176 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/bytecodecompare/prepare_report.py
+10 -1
View File
@@ -66,10 +66,19 @@ def load_source(path: Union[Path, str]) -> str:
def parse_standard_json_output(source_file_name: Path, standard_json_output: str) -> FileReport:
decoded_json_output = json.loads(standard_json_output.strip())
# JSON interface still returns contract metadata in case of an internal compiler error while
# CLI interface does not. To make reports comparable we must force this case to be detected as
# an error in both cases.
internal_compiler_error = any(
error['type'] in ['UnimplementedFeatureError', 'CompilerError', 'CodeGenerationError']
for error in decoded_json_output.get('errors', {})
)
if (
'contracts' not in decoded_json_output or
len(decoded_json_output['contracts']) == 0 or
all(len(file_results) == 0 for file_name, file_results in decoded_json_output['contracts'].items())
all(len(file_results) == 0 for file_name, file_results in decoded_json_output['contracts'].items()) or
internal_compiler_error
):
return FileReport(file_name=source_file_name, contract_reports=None)