cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #2635 from ethereum/fixCrashOnAssignmentToNonLValue

Browse Source 
Fix crash on assignment to non-LValue
This commit is contained in:
Alex Beregszaszi 2017-07-27 13:59:22 +01:00 committed by GitHub
commit 53f747b7de
3 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog.md
View File

@ -12,6 +12,7 @@ Features:
* Type checker: Warn when existing symbols, including builtins, are overwritten. * Type checker: Warn when existing symbols, including builtins, are overwritten.
Bugfixes: Bugfixes:
* Type Checker: Fix crash for some assignment to non-lvalue.
* Type Checker: Fix invalid "specify storage keyword" warning for reference members of structs. * Type Checker: Fix invalid "specify storage keyword" warning for reference members of structs.
* Type Checker: Mark modifiers as internal. * Type Checker: Mark modifiers as internal.
* Type Checker: Re-allow multiple mentions of the same modifier per function. * Type Checker: Re-allow multiple mentions of the same modifier per function.

4
libsolidity/analysis/TypeChecker.cpp
View File

@ -1122,7 +1122,9 @@ bool TypeChecker::visit(Assignment const& _assignment)
_assignment.annotation().type = make_shared<TupleType>(); _assignment.annotation().type = make_shared<TupleType>();
expectType(_assignment.rightHandSide(), *tupleType); expectType(_assignment.rightHandSide(), *tupleType);
checkDoubleStorageAssignment(_assignment); // expectType does not cause fatal errors, so we have to check again here.
if (dynamic_cast<TupleType const*>(type(_assignment.rightHandSide()).get()))
checkDoubleStorageAssignment(_assignment);
} }
else if (t->category() == Type::Category::Mapping) else if (t->category() == Type::Category::Mapping)
{ {

14
test/libsolidity/SolidityNameAndTypeResolution.cpp
View File

@ -6437,6 +6437,20 @@ BOOST_AUTO_TEST_CASE(using_this_in_constructor)
CHECK_WARNING(text, "\"this\" used in constructor"); CHECK_WARNING(text, "\"this\" used in constructor");
} }
BOOST_AUTO_TEST_CASE(do_not_crash_on_not_lalue)
{
// This checks for a bug that caused a crash because of continued analysis.
char const* text = R"(
contract C {
mapping (uint => uint) m;
function f() {
m(1) = 2;
}
}
)";
CHECK_ERROR_ALLOW_MULTI(text, TypeError, "is not callable");
}
BOOST_AUTO_TEST_SUITE_END() BOOST_AUTO_TEST_SUITE_END()
} }