Merge pull request #9782 from ethereum/smt-revert

[SMTChecker] Support revert()

test/libsolidity/smtCheckerTests/control_flow/require.sol

@@ -0,0 +1,33 @@
+pragma experimental SMTChecker;
+
+contract C {
+	function f() pure public {
+		require(false);
+		// This is not reachable.
+		assert(false);
+	}
+
+	function g() pure public {
+		require(false, "require message");
+		// This is not reachable.
+		assert(false);
+	}
+
+	function h(bool b) pure public {
+		if (b)
+			require(false);
+		assert(!b);
+	}
+
+	// Check that arguments are evaluated.
+	bool x = false;
+	function m() view internal returns (string memory) {
+		assert(x != true);
+	}
+	function i() public {
+		x = true;
+		require(false, m());
+	}
+}
+// ----
+// Warning 6328: (448-465): Assertion violation happens here.

test/libsolidity/smtCheckerTests/control_flow/revert.sol

@@ -0,0 +1,35 @@
+pragma experimental SMTChecker;
+
+contract C {
+	function f() pure public {
+		revert();
+		// This is not reachable.
+		assert(false);
+	}
+
+	function g() pure public {
+		revert("revert message");
+		// This is not reachable.
+		assert(false);
+	}
+
+	function h(bool b) pure public {
+		if (b)
+			revert();
+		assert(!b);
+	}
+
+	// Check that arguments are evaluated.
+	bool x = false;
+	function m() view internal returns (string memory) {
+		assert(x != true);
+	}
+	function i() public {
+		x = true;
+		revert(m());
+	}
+}
+// ----
+// Warning 5740: (116-129): Unreachable code.
+// Warning 5740: (221-234): Unreachable code.
+// Warning 6328: (427-444): Assertion violation happens here.

test/libsolidity/smtCheckerTests/control_flow/revert_complex_flow.sol

@@ -0,0 +1,18 @@
+pragma experimental SMTChecker;
+
+contract C {
+	function f(bool b, uint a) pure public {
+		require(a <= 256);
+		if (b)
+			revert();
+		uint c = a + 1;
+		if (b)
+			c--;
+		else
+			c++;
+		assert(c == a);
+	}
+}
+// ----
+// Warning 6328: (183-197): Assertion violation happens here.
+// Warning 6838: (155-156): Condition is always false.

test/libsolidity/smtCheckerTests/verification_target/constant_condition_1.sol

@@ -6,4 +6,3 @@ contract C {
 }
 // ----
 // Warning 6838: (94-100): Condition is always true.
-// Warning 4588: (104-112): Assertion checker does not yet implement this type of function call.

test/libsolidity/smtCheckerTests/verification_target/constant_condition_2.sol

@@ -6,4 +6,3 @@ contract C {
 }
 // ----
 // Warning 6838: (109-115): Condition is always false.
-// Warning 4588: (119-127): Assertion checker does not yet implement this type of function call.

test/libsolidity/smtCheckerTests/verification_target/constant_condition_3.sol

@@ -6,4 +6,3 @@ contract C {
     }
 }
 // ----
-// Warning 4588: (136-144): Assertion checker does not yet implement this type of function call.