From 531ea366625f1d12011d5688eb99f3a60d0766a2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kamil=20=C5=9Aliwak?= <kamil.sliwak@codepoets.it>
Date: Mon, 11 Oct 2021 13:30:08 +0200
Subject: [PATCH] Don't return an error from --help

---
 solc/CommandLineInterface.cpp      | 2 +-
 test/solc/CommandLineInterface.cpp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/solc/CommandLineInterface.cpp b/solc/CommandLineInterface.cpp
index 1358dd484..9d2279910 100644
--- a/solc/CommandLineInterface.cpp
+++ b/solc/CommandLineInterface.cpp
@@ -607,7 +607,7 @@ bool CommandLineInterface::processInput()
 	{
 	case InputMode::Help:
 		CommandLineParser::printHelp(sout());
-		return false;
+		break;
 	case InputMode::License:
 		printLicense();
 		break;
diff --git a/test/solc/CommandLineInterface.cpp b/test/solc/CommandLineInterface.cpp
index 739213e8f..0269ec462 100644
--- a/test/solc/CommandLineInterface.cpp
+++ b/test/solc/CommandLineInterface.cpp
@@ -116,7 +116,7 @@ BOOST_AUTO_TEST_CASE(help)
 {
 	OptionsReaderAndMessages result = parseCommandLineAndReadInputFiles({"solc", "--help"}, "", /* _processInput */ true);
 
-	BOOST_TEST(!result.success);
+	BOOST_TEST(result.success);
 	BOOST_TEST(boost::starts_with(result.stdoutContent, "solc, the Solidity commandline compiler."));
 	BOOST_TEST(result.stderrContent == "");
 	BOOST_TEST(result.options.input.mode == InputMode::Help);