cerc-io/solidity
15
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

removed unneccessary check from ExpresiionCompiler

Browse Source
This commit is contained in:
LianaHus 2015-09-10 10:20:16 +02:00
parent dd3b0664c6
commit 5291467a26
1 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
libsolidity/ExpressionCompiler.cpp
View File

@ -821,7 +821,6 @@ bool ExpressionCompiler::visit(IndexAccess const& _indexAccess)
_indexAccess.baseExpression().accept(*this); _indexAccess.baseExpression().accept(*this);
Type const& baseType = *_indexAccess.baseExpression().type(); Type const& baseType = *_indexAccess.baseExpression().type();
Type const& indexType = *_indexAccess.indexExpression()->type();
if (baseType.category() == Type::Category::Mapping) if (baseType.category() == Type::Category::Mapping)
{ {
@ -863,21 +862,8 @@ bool ExpressionCompiler::visit(IndexAccess const& _indexAccess)
solAssert(_indexAccess.indexExpression(), "Index expression expected."); solAssert(_indexAccess.indexExpression(), "Index expression expected.");
_indexAccess.indexExpression()->accept(*this); _indexAccess.indexExpression()->accept(*this);
// check for dynamically sized arrays should be done after memberAccess visit to have length
if (
(indexType.category() == Type::Category::IntegerConstant) &&
((arrayType.isDynamicallySized() && arrayType.length()) || !arrayType.isDynamicallySized())
)
{
IntegerConstantType const& constant = dynamic_cast<IntegerConstantType const&>(indexType);
if (arrayType.length() < constant.literalValue(nullptr))
BOOST_THROW_EXCEPTION(CompilerError() << errinfo_comment("Out of bounds access."));
}
// stack layout: <base_ref> [<length>] <index> // stack layout: <base_ref> [<length>] <index>
ArrayUtils(m_context).accessIndex(arrayType); ArrayUtils(m_context).accessIndex(arrayType);
switch (arrayType.location()) switch (arrayType.location())
{ {
case DataLocation::Storage: case DataLocation::Storage: