cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #2852 from ssuman/develop

Browse Source 
This commit will display warning when there is unused function parameter
This commit is contained in:
chriseth 2017-09-12 17:57:55 +02:00 committed by GitHub
commit 5084a9cda9
3 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog.md
View File

@ -2,6 +2,7 @@
Features: Features:
* Optimizer: Add new optimization step to remove unused ``JUMPDEST``s. * Optimizer: Add new optimization step to remove unused ``JUMPDEST``s.
* Type Checker: Display helpful warning for unused function arguments/return parameters.
* Type Checker: Do not show the same error multiple times for events. * Type Checker: Do not show the same error multiple times for events.
* Type Checker: Warn on using literals as tight packing parameters in ``keccak256``, ``sha3``, ``sha256`` and ``ripemd160``. * Type Checker: Warn on using literals as tight packing parameters in ``keccak256``, ``sha3``, ``sha256`` and ``ripemd160``.

11
libsolidity/analysis/StaticAnalyzer.cpp
View File

@ -69,7 +69,16 @@ void StaticAnalyzer::endVisit(FunctionDefinition const&)
m_constructor = false; m_constructor = false;
for (auto const& var: m_localVarUseCount) for (auto const& var: m_localVarUseCount)
if (var.second == 0) if (var.second == 0)
m_errorReporter.warning(var.first->location(), "Unused local variable"); {
if (var.first->isCallableParameter())
m_errorReporter.warning(
var.first->location(),
"Unused function parameter. Remove or comment out the variable name to silence this warning."
);
else
m_errorReporter.warning(var.first->location(), "Unused local variable.");
}
m_localVarUseCount.clear(); m_localVarUseCount.clear();
} }

14
test/libsolidity/SolidityNameAndTypeResolution.cpp
View File

@ -5816,7 +5816,7 @@ BOOST_AUTO_TEST_CASE(warn_unused_local)
} }
} }
)"; )";
CHECK_WARNING(text, "Unused"); CHECK_WARNING(text, "Unused local variable.");
} }
BOOST_AUTO_TEST_CASE(warn_unused_local_assigned) BOOST_AUTO_TEST_CASE(warn_unused_local_assigned)
@ -5828,10 +5828,10 @@ BOOST_AUTO_TEST_CASE(warn_unused_local_assigned)
} }
} }
)"; )";
CHECK_WARNING(text, "Unused"); CHECK_WARNING(text, "Unused local variable.");
} }
BOOST_AUTO_TEST_CASE(warn_unused_param) BOOST_AUTO_TEST_CASE(warn_unused_function_parameter)
{ {
char const* text = R"( char const* text = R"(
contract C { contract C {
@ -5839,7 +5839,7 @@ BOOST_AUTO_TEST_CASE(warn_unused_param)
} }
} }
)"; )";
CHECK_WARNING(text, "Unused"); CHECK_WARNING(text, "Unused function parameter. Remove or comment out the variable name to silence this warning.");
text = R"( text = R"(
contract C { contract C {
function f(uint a) { function f(uint a) {
@ -5849,7 +5849,7 @@ BOOST_AUTO_TEST_CASE(warn_unused_param)
success(text); success(text);
} }
BOOST_AUTO_TEST_CASE(warn_unused_return_param) BOOST_AUTO_TEST_CASE(warn_unused_return_parameter)
{ {
char const* text = R"( char const* text = R"(
contract C { contract C {
@ -5857,7 +5857,7 @@ BOOST_AUTO_TEST_CASE(warn_unused_return_param)
} }
} }
)"; )";
CHECK_WARNING(text, "Unused"); CHECK_WARNING(text, "Unused function parameter. Remove or comment out the variable name to silence this warning.");
text = R"( text = R"(
contract C { contract C {
function f() returns (uint a) { function f() returns (uint a) {
@ -5865,7 +5865,7 @@ BOOST_AUTO_TEST_CASE(warn_unused_return_param)
} }
} }
)"; )";
CHECK_WARNING(text, "Unused"); CHECK_WARNING(text, "Unused function parameter. Remove or comment out the variable name to silence this warning.");
text = R"( text = R"(
contract C { contract C {
function f() returns (uint) { function f() returns (uint) {