cerc-io/solidity
11
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #2703 from ethereum/warnAboutLargeStorageArrays

Browse Source 
Warn about large storage structures.
This commit is contained in:
chriseth
2017-08-14 11:37:01 +02:00
committed by GitHub
parent 52ccc26494 da3ac86403
commit 4d9790b6d5
4 changed files with 97 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/libsolidity/SolidityNameAndTypeResolution.cpp
+51
View File
@@ -6545,6 +6545,57 @@ BOOST_AUTO_TEST_CASE(constructor_without_implementation)
CHECK_ERROR(text, TypeError, "Constructor must be implemented if declared.");
}
BOOST_AUTO_TEST_CASE(large_storage_array_fine)
{
char const* text = R"(
contract C {
uint[2**64 - 1] x;
}
)";
CHECK_SUCCESS_NO_WARNINGS(text);
}
BOOST_AUTO_TEST_CASE(large_storage_array_simple)
{
char const* text = R"(
contract C {
uint[2**64] x;
}
)";
CHECK_WARNING(text, "covers a large part of storage and thus makes collisions likely");
}
BOOST_AUTO_TEST_CASE(large_storage_arrays_combined)
{
char const* text = R"(
contract C {
uint[200][200][2**30][][2**30] x;
}
)";
CHECK_WARNING(text, "covers a large part of storage and thus makes collisions likely");
}
BOOST_AUTO_TEST_CASE(large_storage_arrays_struct)
{
char const* text = R"(
contract C {
struct S { uint[2**30] x; uint[2**50] y; }
S[2**20] x;
}
)";
CHECK_WARNING(text, "covers a large part of storage and thus makes collisions likely");
}
BOOST_AUTO_TEST_CASE(large_storage_array_mapping)
{
char const* text = R"(
contract C {
mapping(uint => uint[2**100]) x;
}
)";
CHECK_WARNING(text, "covers a large part of storage and thus makes collisions likely");
}
BOOST_AUTO_TEST_CASE(library_function_without_implementation)
{
char const* text = R"(