cerc-io/solidity
15
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

coding standards, documentation, new exception syntax

Browse Source
This commit is contained in:
subtly 2014-11-05 14:13:27 +01:00
parent 127747fd4e
commit 4aeeb68d77
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
crypto.cpp
View File

@ -92,7 +92,7 @@ BOOST_AUTO_TEST_CASE(cryptopp_vs_secp256k1)
} }
} }
BOOST_AUTO_TEST_CASE(cryptopp_cryptopp_ecdsav) BOOST_AUTO_TEST_CASE(cryptopp_cryptopp_secp256k1libport)
{ {
// cryptopp implementation of secp256k1lib sign_compact w/recid parameter and recovery of public key from signature // cryptopp implementation of secp256k1lib sign_compact w/recid parameter and recovery of public key from signature
@ -128,6 +128,12 @@ BOOST_AUTO_TEST_CASE(cryptopp_cryptopp_ecdsav)
Integer s = (kInv * (Integer(secret.asBytes().data(), 32)*r + heInt)) % q; Integer s = (kInv * (Integer(secret.asBytes().data(), 32)*r + heInt)) % q;
BOOST_REQUIRE(!!r && !!s); BOOST_REQUIRE(!!r && !!s);
/*
// For future reference:
// According to maths, this codepath can't be reached, however, it's in secp256k1.
// Commenting this out diverges from codebase implementation.
// To be removed after upstream PR and proof are evaulated.
if (s > params.GetSubgroupOrder()) if (s > params.GetSubgroupOrder())
{ {
// note: this rarely happens // note: this rarely happens
@ -135,6 +141,7 @@ BOOST_AUTO_TEST_CASE(cryptopp_cryptopp_ecdsav)
if (recid) if (recid)
recid ^= 1; recid ^= 1;
} }
*/
Signature sig; Signature sig;
r.Encode(sig.data(), 32); r.Encode(sig.data(), 32);