From 444e84412052397fc4a8f4fdcceb62b3ef65be2e Mon Sep 17 00:00:00 2001
From: Mathias Baumann <marenz@supradigital.org>
Date: Tue, 1 Jun 2021 17:20:45 +0200
Subject: [PATCH] Cache calls to ``definedFunctions()``

---
 libsolidity/ast/AST.cpp | 8 ++++++++
 libsolidity/ast/AST.h   | 3 ++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/libsolidity/ast/AST.cpp b/libsolidity/ast/AST.cpp
index 537846007..2c218033e 100644
--- a/libsolidity/ast/AST.cpp
+++ b/libsolidity/ast/AST.cpp
@@ -149,6 +149,14 @@ FunctionDefinition const* ContractDefinition::receiveFunction() const
 	return nullptr;
 }
 
+std::vector<FunctionDefinition const*> const& ContractDefinition::definedFunctions() const
+{
+	if (!m_cachedDefinedFunctions)
+		m_cachedDefinedFunctions = filteredNodes<FunctionDefinition>(m_subNodes);
+
+	return *m_cachedDefinedFunctions;
+}
+
 vector<EventDefinition const*> const& ContractDefinition::interfaceEvents() const
 {
 	return m_interfaceEvents.init([&]{
diff --git a/libsolidity/ast/AST.h b/libsolidity/ast/AST.h
index 7a1609e81..73cbb9d1d 100644
--- a/libsolidity/ast/AST.h
+++ b/libsolidity/ast/AST.h
@@ -496,7 +496,7 @@ public:
 	std::vector<EnumDefinition const*> definedEnums() const { return filteredNodes<EnumDefinition>(m_subNodes); }
 	std::vector<VariableDeclaration const*> stateVariables() const { return filteredNodes<VariableDeclaration>(m_subNodes); }
 	std::vector<ModifierDefinition const*> functionModifiers() const { return filteredNodes<ModifierDefinition>(m_subNodes); }
-	std::vector<FunctionDefinition const*> definedFunctions() const { return filteredNodes<FunctionDefinition>(m_subNodes); }
+	std::vector<FunctionDefinition const*> const& definedFunctions() const;
 	std::vector<EventDefinition const*> events() const { return filteredNodes<EventDefinition>(m_subNodes); }
 	std::vector<EventDefinition const*> const& interfaceEvents() const;
 	/// @returns all errors defined in this contract or any base contract
@@ -549,6 +549,7 @@ private:
 	std::vector<ASTPointer<InheritanceSpecifier>> m_baseContracts;
 	std::vector<ASTPointer<ASTNode>> m_subNodes;
 	ContractKind m_contractKind;
+	mutable std::optional<std::vector<FunctionDefinition const*>> m_cachedDefinedFunctions;
 	bool m_abstract{false};
 
 	util::LazyInit<std::vector<std::pair<util::FixedHash<4>, FunctionTypePointer>>> m_interfaceFunctionList[2];