cerc-io/solidity
11
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Implement and fix overriding unimplemented and implemented functions with unimplemented functions.

Browse Source
This commit is contained in:
Daniel Kirchner
2019-12-05 09:26:43 +01:00
committed by chriseth
parent 2c72ee7017
commit 426f04b389
5 changed files with 37 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/libsolidity/syntaxTests/inheritance/override/override_unimplemented_fail.sol
+15
View File
@@ -0,0 +1,15 @@
abstract contract A {
function f() external virtual;
}
abstract contract B {
function f() external virtual {}
}
abstract contract C is A, B {
function f() external virtual override(A, B);
}
abstract contract D is B, A {
function f() external virtual override(A, B);
}
// ----
// TypeError: (154-199): Overriding an implemented function with an unimplemented function is not allowed.
// TypeError: (236-281): Overriding an implemented function with an unimplemented function is not allowed.
test/libsolidity/syntaxTests/inheritance/override/override_unimplemented_fine.sol
+9
View File
@@ -0,0 +1,9 @@
interface A {
function f() external;
}
interface B {
function f() external;
}
abstract contract C is A, B {
function f() external virtual override(A, B);
}
test/libsolidity/syntaxTests/nameAndTypeResolution/030_redeclare_implemented_abstract_function_as_abstract.sol
+1 -1
View File
@@ -2,4 +2,4 @@ abstract contract base { function foo() public virtual; }
contract derived is base { function foo() public virtual override {} }
contract wrong is derived { function foo() public virtual override; }
// ----
// TypeError: (157-196): Redeclaring an already implemented function as abstract
// TypeError: (157-196): Overriding an implemented function with an unimplemented function is not allowed.