cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Disable large arrays for memory location too

Browse Source
This commit is contained in:
Alex Beregszaszi 2017-07-13 17:02:10 +02:00
parent e640bb2aed
commit 4229caaadc
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libsolidity/analysis/TypeChecker.cpp
View File

@ -586,7 +586,11 @@ bool TypeChecker::visit(VariableDeclaration const& _variable)
if (varType->category() == Type::Category::Array) if (varType->category() == Type::Category::Array)
if (auto arrayType = dynamic_cast<ArrayType const*>(varType.get())) if (auto arrayType = dynamic_cast<ArrayType const*>(varType.get()))
if ((arrayType->location() == DataLocation::CallData) && !arrayType->validForCalldata()) if (
((arrayType->location() == DataLocation::Memory) ||
(arrayType->location() == DataLocation::CallData)) &&
!arrayType->validForCalldata()
)
m_errorReporter.typeError(_variable.location(), "Array is too large to be encoded as calldata."); m_errorReporter.typeError(_variable.location(), "Array is too large to be encoded as calldata.");
return false; return false;

2
test/libsolidity/SolidityNameAndTypeResolution.cpp
View File

@ -6319,7 +6319,7 @@ BOOST_AUTO_TEST_CASE(too_large_arrays_for_calldata)
} }
} }
)"; )";
CHECK_SUCCESS_NO_WARNINGS(text); CHECK_ERROR(text, TypeError, "Array is too large to be encoded as calldata.");
} }
BOOST_AUTO_TEST_SUITE_END() BOOST_AUTO_TEST_SUITE_END()