From ae6251effd0474cd25379f09148da95b3486e9b4 Mon Sep 17 00:00:00 2001 From: Alex Beregszaszi Date: Fri, 9 Jun 2017 11:36:36 +0100 Subject: [PATCH 1/2] Use inline assembly directly and not via AsmStack --- libsolidity/codegen/CompilerContext.cpp | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/libsolidity/codegen/CompilerContext.cpp b/libsolidity/codegen/CompilerContext.cpp index 9c4fbcbbb..d98efcadc 100644 --- a/libsolidity/codegen/CompilerContext.cpp +++ b/libsolidity/codegen/CompilerContext.cpp @@ -25,8 +25,11 @@ #include #include #include -#include -#include +#include +#include +#include +#include +#include #include @@ -302,7 +305,18 @@ void CompilerContext::appendInlineAssembly( } }; - solAssert(assembly::InlineAssemblyStack().parseAndAssemble(*assembly, *m_asm, identifierAccess), "Failed to assemble inline assembly block."); + ErrorList errors; + ErrorReporter errorReporter(errors); + auto scanner = make_shared(CharStream(*assembly), "--CODEGEN--"); + auto parserResult = assembly::Parser(errorReporter).parse(scanner); + solAssert(parserResult, "Failed to parse inline assembly block."); + solAssert(errorReporter.errors().empty(), "Failed to parse inline assembly block."); + + assembly::AsmAnalysisInfo analysisInfo; + assembly::AsmAnalyzer analyzer(analysisInfo, errorReporter, false, identifierAccess.resolve); + solAssert(analyzer.analyze(*parserResult), "Failed to analyze inline assembly block."); + solAssert(errorReporter.errors().empty(), "Failed to analyze inline assembly block."); + assembly::CodeGenerator::assemble(*parserResult, analysisInfo, *m_asm, identifierAccess); } FunctionDefinition const& CompilerContext::resolveVirtualFunction( From 114c157b04f0ea1429b67d52c35e32f13c5ae9a4 Mon Sep 17 00:00:00 2001 From: Alex Beregszaszi Date: Fri, 9 Jun 2017 11:36:56 +0100 Subject: [PATCH 2/2] Remove obsolete AsmStack --- libjulia/backends/evm/EVMCodeTransform.h | 1 - libsolidity/inlineasm/AsmStack.cpp | 96 ------------------------ libsolidity/inlineasm/AsmStack.h | 79 ------------------- 3 files changed, 176 deletions(-) delete mode 100644 libsolidity/inlineasm/AsmStack.cpp delete mode 100644 libsolidity/inlineasm/AsmStack.h diff --git a/libjulia/backends/evm/EVMCodeTransform.h b/libjulia/backends/evm/EVMCodeTransform.h index 6031d1a81..f65948dc1 100644 --- a/libjulia/backends/evm/EVMCodeTransform.h +++ b/libjulia/backends/evm/EVMCodeTransform.h @@ -20,7 +20,6 @@ #include -#include #include #include diff --git a/libsolidity/inlineasm/AsmStack.cpp b/libsolidity/inlineasm/AsmStack.cpp deleted file mode 100644 index 92eb8a7ac..000000000 --- a/libsolidity/inlineasm/AsmStack.cpp +++ /dev/null @@ -1,96 +0,0 @@ -/* - This file is part of solidity. - - solidity is free software: you can redistribute it and/or modify - it under the terms of the GNU General Public License as published by - the Free Software Foundation, either version 3 of the License, or - (at your option) any later version. - - solidity is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU General Public License for more details. - - You should have received a copy of the GNU General Public License - along with solidity. If not, see . -*/ -/** - * @author Christian - * @date 2016 - * Full-stack Solidity inline assember. - */ - -#include - -#include -#include -#include -#include -#include - -#include - -#include -#include - -#include - -using namespace std; -using namespace dev; -using namespace dev::solidity; -using namespace dev::solidity::assembly; - -bool InlineAssemblyStack::parse( - shared_ptr const& _scanner, - julia::ExternalIdentifierAccess::Resolver const& _resolver -) -{ - m_parserResult = make_shared(); - Parser parser(m_errorReporter); - auto result = parser.parse(_scanner); - if (!result) - return false; - - *m_parserResult = std::move(*result); - AsmAnalysisInfo analysisInfo; - return (AsmAnalyzer(analysisInfo, m_errorReporter, false, _resolver)).analyze(*m_parserResult); -} - -string InlineAssemblyStack::toString() -{ - return AsmPrinter()(*m_parserResult); -} - -eth::Assembly InlineAssemblyStack::assemble() -{ - AsmAnalysisInfo analysisInfo; - AsmAnalyzer analyzer(analysisInfo, m_errorReporter); - solAssert(analyzer.analyze(*m_parserResult), ""); - return CodeGenerator::assemble(*m_parserResult, analysisInfo); -} - -bool InlineAssemblyStack::parseAndAssemble( - string const& _input, - eth::Assembly& _assembly, - julia::ExternalIdentifierAccess const& _identifierAccess -) -{ - ErrorList errors; - ErrorReporter errorReporter(errors); - auto scanner = make_shared(CharStream(_input), "--CODEGEN--"); - auto parserResult = Parser(errorReporter).parse(scanner); - if (!errorReporter.errors().empty()) - return false; - solAssert(parserResult, ""); - - AsmAnalysisInfo analysisInfo; - AsmAnalyzer analyzer(analysisInfo, errorReporter, false, _identifierAccess.resolve); - solAssert(analyzer.analyze(*parserResult), ""); - solAssert(errorReporter.errors().empty(), ""); - CodeGenerator::assemble(*parserResult, analysisInfo, _assembly, _identifierAccess); - - // At this point, the assembly might be messed up, but we should throw an - // internal compiler error anyway. - return errorReporter.errors().empty(); -} - diff --git a/libsolidity/inlineasm/AsmStack.h b/libsolidity/inlineasm/AsmStack.h deleted file mode 100644 index 7452804d7..000000000 --- a/libsolidity/inlineasm/AsmStack.h +++ /dev/null @@ -1,79 +0,0 @@ -/* - This file is part of solidity. - - solidity is free software: you can redistribute it and/or modify - it under the terms of the GNU General Public License as published by - the Free Software Foundation, either version 3 of the License, or - (at your option) any later version. - - solidity is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU General Public License for more details. - - You should have received a copy of the GNU General Public License - along with solidity. If not, see . -*/ -/** - * @author Christian - * @date 2016 - * Full-stack Solidity inline assember. - */ - -#pragma once - -#include -#include - -#include -#include - -namespace dev -{ -namespace eth -{ -class Assembly; -} -namespace solidity -{ -class Scanner; -namespace assembly -{ -struct Block; -struct Identifier; - -class InlineAssemblyStack -{ -public: - InlineAssemblyStack(): - m_errorReporter(m_errorList) {} - /// Parse the given inline assembly chunk starting with `{` and ending with the corresponding `}`. - /// @return false or error. - bool parse( - std::shared_ptr const& _scanner, - julia::ExternalIdentifierAccess::Resolver const& _externalIdentifierResolver = julia::ExternalIdentifierAccess::Resolver() - ); - /// Converts the parser result back into a string form (not necessarily the same form - /// as the source form, but it should parse into the same parsed form again). - std::string toString(); - - eth::Assembly assemble(); - - /// Parse and assemble a string in one run - for use in Solidity code generation itself. - bool parseAndAssemble( - std::string const& _input, - eth::Assembly& _assembly, - julia::ExternalIdentifierAccess const& _identifierAccess = julia::ExternalIdentifierAccess() - ); - - ErrorList const& errors() const { return m_errorReporter.errors(); } - -private: - std::shared_ptr m_parserResult; - ErrorList m_errorList; - ErrorReporter m_errorReporter; -}; - -} -} -}