cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Disable blockhash test for constantinople due to changes between aleth versions.

Browse Source
This commit is contained in:
Daniel Kirchner 2018-09-13 17:18:42 +02:00
parent 583b87bb3d
commit 3e55aa3fa2
1 changed files with 20 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
test/libsolidity/SolidityEndToEndTest.cpp
View File

@ -3039,26 +3039,26 @@ BOOST_AUTO_TEST_CASE(gasprice)
BOOST_AUTO_TEST_CASE(blockhash) BOOST_AUTO_TEST_CASE(blockhash)
{ {
char const* sourceCode = R"( // depending on the aleth version, this test only works for pre-constantinople
contract C {
uint256 counter;
function g() public returns (bool) { counter++; return true; }
function f() public returns (bytes32[] memory r) {
r = new bytes32[](259);
for (uint i = 0; i < 259; i++)
r[i] = blockhash(block.number - 257 + i);
}
}
)";
compileAndRun(sourceCode);
// generate a sufficient amount of blocks
while (blockNumber() < u256(255))
ABI_CHECK(callContractFunction("g()"), encodeArgs(true));
vector<u256> hashes;
// currently the test only works for pre-constantinople
if (Options::get().evmVersion() < EVMVersion::constantinople()) if (Options::get().evmVersion() < EVMVersion::constantinople())
{ {
char const* sourceCode = R"(
contract C {
uint256 counter;
function g() public returns (bool) { counter++; return true; }
function f() public returns (bytes32[] memory r) {
r = new bytes32[](259);
for (uint i = 0; i < 259; i++)
r[i] = blockhash(block.number - 257 + i);
}
}
)";
compileAndRun(sourceCode);
// generate a sufficient amount of blocks
while (blockNumber() < u256(255))
ABI_CHECK(callContractFunction("g()"), encodeArgs(true));
vector<u256> hashes;
// ``blockhash()`` is only valid for the last 256 blocks, otherwise zero // ``blockhash()`` is only valid for the last 256 blocks, otherwise zero
hashes.emplace_back(0); hashes.emplace_back(0);
for (u256 i = blockNumber() - u256(255); i <= blockNumber(); i++) for (u256 i = blockNumber() - u256(255); i <= blockNumber(); i++)
@ -3067,18 +3067,9 @@ BOOST_AUTO_TEST_CASE(blockhash)
hashes.emplace_back(0); hashes.emplace_back(0);
// future block hashes are zero // future block hashes are zero
hashes.emplace_back(0); hashes.emplace_back(0);
}
else
// TODO: Starting from constantinople blockhash always seems to return zero.
// The blockhash contract introduced in EIP96 seems to break in our setup of
// aleth (setting the constantinople fork block to zero and resetting the chain
// to block zero before each test run). Pre-deploying the blockchain contract
// during genesis seems to help, but currently causes problems with other tests.
// Set the expectation to zero for now, so that this test tracks changes in this
// behavior.
hashes.assign(259, 0);
ABI_CHECK(callContractFunction("f()"), encodeDyn(hashes)); ABI_CHECK(callContractFunction("f()"), encodeDyn(hashes));
}
} }
BOOST_AUTO_TEST_CASE(value_complex) BOOST_AUTO_TEST_CASE(value_complex)