Merge pull request #9246 from ethereum/fixErrors

Fix error IDs on the breaking branch.

test/libsolidity/smtCheckerTests/special/many.sol

@@ -15,12 +15,12 @@ contract C
 	}
 }
 // ----
-// Warning: (79-115): Assertion violation happens here
-// Warning: (119-161): Assertion violation happens here
-// Warning: (165-204): Assertion violation happens here
-// Warning: (208-240): Assertion violation happens here
-// Warning: (244-275): Assertion violation happens here
-// Warning: (311-316): Overflow (resulting value larger than 2**256 - 1) happens here
-// Warning: (304-332): Assertion violation happens here
-// Warning: (336-364): Assertion violation happens here
-// Warning: (368-391): Assertion violation happens here
+// Warning 4661: (79-115): Assertion violation happens here
+// Warning 4661: (119-161): Assertion violation happens here
+// Warning 4661: (165-204): Assertion violation happens here
+// Warning 4661: (208-240): Assertion violation happens here
+// Warning 4661: (244-275): Assertion violation happens here
+// Warning 2661: (311-316): Overflow (resulting value larger than 2**256 - 1) happens here
+// Warning 4661: (304-332): Assertion violation happens here
+// Warning 4661: (336-364): Assertion violation happens here
+// Warning 4661: (368-391): Assertion violation happens here

test/libsolidity/smtCheckerTests/types/function_type_members.sol

@@ -6,4 +6,4 @@ contract C {
     }
 }
 // ----
-// Warning: (108-118): Assertion checker does not yet support this expression.
+// Warning 7650: (108-118): Assertion checker does not yet support this expression.

test/libsolidity/syntaxTests/functionCalls/calloptions_repeated.sol

@@ -11,9 +11,9 @@ contract C {
 // ====
 // EVMVersion: >=constantinople
 // ----
-// TypeError: (78-110): Option "gas" has already been set.
-// TypeError: (120-154): Option "gas" has already been set.
-// TypeError: (164-198): Option "value" has already been set.
-// TypeError: (208-249): Option "value" has already been set.
-// TypeError: (208-249): Option "gas" has already been set.
-// TypeError: (259-286): Option "salt" has already been set.
+// TypeError 9886: (78-110): Option "gas" has already been set.
+// TypeError 9886: (120-154): Option "gas" has already been set.
+// TypeError 9886: (164-198): Option "value" has already been set.
+// TypeError 9886: (208-249): Option "value" has already been set.
+// TypeError 9886: (208-249): Option "gas" has already been set.
+// TypeError 9886: (259-286): Option "salt" has already been set.

test/libsolidity/syntaxTests/functionTypes/call_value_on_non_payable_function_type.sol

@@ -5,4 +5,4 @@ contract C {
     }
 }
 // ----
-// TypeError: (94-105): Cannot set option "value" on a non-payable function type.
+// TypeError 7006: (94-105): Cannot set option "value" on a non-payable function type.

test/libsolidity/syntaxTests/functionTypes/error_deprecate_gas_function.sol

@@ -5,4 +5,4 @@ contract C {
     }
 }
 // ----
-// TypeError: (102-107): Using ".gas(...)" is deprecated. Use "{gas: ...}" instead.
+// TypeError 1621: (102-107): Using ".gas(...)" is deprecated. Use "{gas: ...}" instead.

test/libsolidity/syntaxTests/functionTypes/error_deprecate_value_constructor.sol

@@ -8,4 +8,4 @@ contract D {
     }
 }
 // ----
-// TypeError: (122-135): Using ".value(...)" is deprecated. Use "{value: ...}" instead.
+// TypeError 1621: (122-135): Using ".value(...)" is deprecated. Use "{value: ...}" instead.

test/libsolidity/syntaxTests/functionTypes/error_deprecate_value_function.sol

@@ -5,4 +5,4 @@ contract C {
     }
 }
 // ----
-// TypeError: (102-109): Using ".value(...)" is deprecated. Use "{value: ...}" instead.
+// TypeError 1621: (102-109): Using ".value(...)" is deprecated. Use "{value: ...}" instead.

test/libsolidity/syntaxTests/globalFunctions/now_deprecate.sol

@@ -4,4 +4,4 @@ contract C {
 	}
 }
 // ----
-// TypeError: (38-41): "now" has been deprecated. Use "block.timestamp" instead.
+// TypeError 7359: (38-41): "now" has been deprecated. Use "block.timestamp" instead.

test/libsolidity/syntaxTests/globalFunctions/now_override.sol

@@ -5,4 +5,4 @@ contract C {
 	}
 }
 // ----
-// Warning: (43-51): This declaration shadows a builtin symbol.
+// Warning 2319: (43-51): This declaration shadows a builtin symbol.

test/libsolidity/syntaxTests/inheritance/virtual/library_err.sol

@@ -2,4 +2,4 @@ library L {
     function f() internal pure virtual returns (uint) { return 0; }
 }
 // ----
-// TypeError: (16-79): Library functions cannot be "virtual".
+// TypeError 7801: (16-79): Library functions cannot be "virtual".

test/libsolidity/syntaxTests/inlineAssembly/pc.sol

@@ -6,4 +6,4 @@ contract C {
 	}
 }
 // ----
-// SyntaxError: (61-63): PC instruction is a low-level EVM feature. Because of that PC is disallowed in strict assembly.
+// SyntaxError 2450: (61-63): PC instruction is a low-level EVM feature. Because of that PC is disallowed in strict assembly.

test/libsolidity/syntaxTests/missing_functions_duplicate_bug.sol

@@ -23,4 +23,4 @@ contract Voting is Ownable {
     }
 }
 // ----
-// Warning: (299-315): Unused function parameter. Remove or comment out the variable name to silence this warning.
+// Warning 5667: (299-315): Unused function parameter. Remove or comment out the variable name to silence this warning.

test/libsolidity/syntaxTests/nameAndTypeResolution/333_fixed_point_casting_exponents_15.sol

@@ -4,4 +4,4 @@ contract test {
     }
 }
 // ----
-// TypeError: (61-77): Operator ** not compatible with types int_const 3 and ufixed128x18. Exponent is fractional.
+// TypeError 2271: (61-77): Operator ** not compatible with types int_const 3 and ufixed128x18. Exponent is fractional.

test/libsolidity/syntaxTests/nameAndTypeResolution/334_fixed_point_casting_exponents_neg.sol

@@ -4,4 +4,4 @@ contract test {
     }
 }
 // ----
-// TypeError: (61-78): Operator ** not compatible with types int_const 42 and fixed128x18. Exponent is fractional.
+// TypeError 2271: (61-78): Operator ** not compatible with types int_const 42 and fixed128x18. Exponent is fractional.

test/libsolidity/syntaxTests/nameAndTypeResolution/348_unused_return_value_call_value.sol

@@ -4,4 +4,4 @@ contract test {
     }
 }
 // ----
-// Warning: (50-85): Return value of low-level calls not used.
+// Warning 9302: (50-85): Return value of low-level calls not used.

test/libsolidity/syntaxTests/nameAndTypeResolution/363_non_payable_constructor.sol

@@ -8,4 +8,4 @@ contract D {
     }
 }
 // ----
-// TypeError: (106-123): Cannot set option "value", since the constructor of contract C is not payable.
+// TypeError 7006: (106-123): Cannot set option "value", since the constructor of contract C is not payable.

test/libsolidity/syntaxTests/natspec/docstring_author_title_state_variable.sol

@@ -4,5 +4,5 @@ contract C {
     uint private state;
 }
 // ----
-// DocstringParsingError: (17-56): Documentation tag @author not valid for non-public state variables.
-// DocstringParsingError: (17-56): Documentation tag @title not valid for non-public state variables.
+// DocstringParsingError 6546: (17-56): Documentation tag @author not valid for non-public state variables.
+// DocstringParsingError 6546: (17-56): Documentation tag @title not valid for non-public state variables.

test/libsolidity/syntaxTests/natspec/docstring_non_public_state_variable_with_return.sol

@@ -3,4 +3,4 @@ contract test {
   uint private state;
 }
 // ----
-// DocstringParsingError: (18-47): Documentation tag @return not valid for non-public state variables.
+// DocstringParsingError 6546: (18-47): Documentation tag @return not valid for non-public state variables.

test/libsolidity/syntaxTests/natspec/docstring_private_state_variable.sol

@@ -4,4 +4,4 @@ contract C {
     uint private state;
 }
 // ----
-// DocstringParsingError: (17-74): Documentation tag @notice not valid for non-public state variables.
+// DocstringParsingError 6546: (17-74): Documentation tag @notice not valid for non-public state variables.

test/libsolidity/syntaxTests/natspec/docstring_variable.sol

@@ -11,4 +11,4 @@ contract C {
     }
 }
 // ----
-// ParserError: (290-295): Only state variables can have a docstring.
+// ParserError 2837: (290-295): Only state variables can have a docstring.

test/libsolidity/syntaxTests/shifts/shift_singed_rvalue.sol

@@ -7,5 +7,5 @@ contract C {
     }
 }
 // ----
-// TypeError: (89-95): Operator >> not compatible with types int256 and int256
-// TypeError: (179-193): Operator >> not compatible with types int256 and int256
+// TypeError 2271: (89-95): Operator >> not compatible with types int256 and int256
+// TypeError 2271: (179-193): Operator >> not compatible with types int256 and int256

test/libsolidity/syntaxTests/signed_rational_modulus.sol

@@ -7,4 +7,4 @@ contract test {
     }
 }
 // ----
-// TypeError: (117-123): Operator % not compatible with types rational_const 1 / 2 and fixed128x18. Fractional literals not supported.
+// TypeError 2271: (117-123): Operator % not compatible with types rational_const 1 / 2 and fixed128x18. Fractional literals not supported.

test/libsolidity/syntaxTests/viewPureChecker/gas_with_call_nonpayable.sol

@@ -8,5 +8,5 @@ contract C {
 	}
 }
 // ----
-// TypeError: (90-109): Function declared as view, but this expression (potentially) modifies the state and thus requires non-payable (the default) or payable.
-// TypeError: (180-197): Function declared as view, but this expression (potentially) modifies the state and thus requires non-payable (the default) or payable.
+// TypeError 8961: (90-109): Function declared as view, but this expression (potentially) modifies the state and thus requires non-payable (the default) or payable.
+// TypeError 8961: (180-197): Function declared as view, but this expression (potentially) modifies the state and thus requires non-payable (the default) or payable.

test/libsolidity/syntaxTests/viewPureChecker/value_with_call_nonpayable.sol

@@ -8,5 +8,5 @@ contract C {
 	}
 }
 // ----
-// TypeError: (90-111): Function declared as view, but this expression (potentially) modifies the state and thus requires non-payable (the default) or payable.
-// TypeError: (182-201): Function declared as view, but this expression (potentially) modifies the state and thus requires non-payable (the default) or payable.
+// TypeError 8961: (90-111): Function declared as view, but this expression (potentially) modifies the state and thus requires non-payable (the default) or payable.
+// TypeError 8961: (182-201): Function declared as view, but this expression (potentially) modifies the state and thus requires non-payable (the default) or payable.

test/libyul/yulSyntaxTests/pc.yul

@@ -4,4 +4,4 @@
 // ====
 // dialect: evmTyped
 // ----
-// SyntaxError: (10-12): PC instruction is a low-level EVM feature. Because of that PC is disallowed in strict assembly.
+// SyntaxError 2450: (10-12): PC instruction is a low-level EVM feature. Because of that PC is disallowed in strict assembly.