cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fixup! BytesUtils: Don't introduce garbage when formatting byte vectors shorter than expected

Browse Source
This commit is contained in:
Kamil Śliwak 2023-08-17 20:45:16 +02:00
parent 0f5aacefa0
commit 397a5543a4
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/libsolidity/util/BytesUtils.cpp
View File

@ -283,7 +283,10 @@ string BytesUtils::formatRawBytes(
for (auto const& parameter: parameters) for (auto const& parameter: parameters)
{ {
long actualSize = min(distance(it, _bytes.end()), static_cast<long>(parameter.abiType.size)); long actualSize = min(
distance(it, _bytes.end()),
static_cast<ParameterList::difference_type>(parameter.abiType.size)
);
bytes byteRange(parameter.abiType.size, 0); bytes byteRange(parameter.abiType.size, 0);
copy(it, it + actualSize, byteRange.begin()); copy(it, it + actualSize, byteRange.begin());
@ -404,7 +407,10 @@ string BytesUtils::formatBytesRange(
for (auto const& parameter: parameters) for (auto const& parameter: parameters)
{ {
long actualSize = min(distance(it, _bytes.end()), static_cast<long>(parameter.abiType.size)); long actualSize = min(
distance(it, _bytes.end()),
static_cast<ParameterList::difference_type>(parameter.abiType.size)
);
bytes byteRange(parameter.abiType.size, 0); bytes byteRange(parameter.abiType.size, 0);
copy(it, it + actualSize, byteRange.begin()); copy(it, it + actualSize, byteRange.begin());