cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #6080 from ethereum/library-index-access

Browse Source 
Disallow index access on contracts and libraries
This commit is contained in:
chriseth 2019-02-26 13:26:05 +01:00 committed by GitHub
commit 38fc740690
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog.md
View File

@ -19,6 +19,7 @@ Bugfixes:
* Inline Assembly: Proper error message for missing variables.
* Optimizer: Fix internal error related to unused tag removal across assemblies. This never generated any invalid code.
* SMTChecker: Fixed crash when used with fixed-sized arrays.
* TypeChecker: Fix internal error and disallow index access on contracts and libraries.
* Yul: Properly detect name clashes with functions before their declaration.
* Yul: Take builtin functions into account in the compilability checker.

2
libsolidity/analysis/TypeChecker.cpp
View File

@ -2208,6 +2208,8 @@ bool TypeChecker::visit(IndexAccess const& _access)
case Type::Category::TypeType:
{
TypeType const& typeType = dynamic_cast<TypeType const&>(*baseType);
if (dynamic_cast<ContractType const*>(typeType.actualType().get()))
m_errorReporter.typeError(_access.location(), "Index access for contracts or libraries is not possible.");
if (!index)
resultType = make_shared<TypeType>(make_shared<ArrayType>(DataLocation::Memory, typeType.actualType()));
else

11
test/libsolidity/syntaxTests/array/contract_array.sol Normal file
View File

@ -0,0 +1,11 @@
contract C {
C[] y = new C[](3);
C[3] x;
function f() public {
C[3] memory z;
y.push(this);
x[0] = this;
z[0] = this;
}
}

7
test/libsolidity/syntaxTests/array/invalid/contract_index_access.sol Normal file
View File

@ -0,0 +1,7 @@
contract C {
function f() view public {
C[0];
}
}
// ----
// TypeError: (52-56): Index access for contracts or libraries is not possible.

7
test/libsolidity/syntaxTests/array/invalid/library_index_access.sol Normal file
View File

@ -0,0 +1,7 @@
library C {
function f() view public {
C[0];
}
}
// ----
// TypeError: (51-55): Index access for contracts or libraries is not possible.