cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #10617 from ethereum/codegen-fixed-assert

Browse Source 
Unary minus is not implemented for fixed point type
This commit is contained in:
chriseth 2020-12-15 19:25:51 +01:00 committed by GitHub
commit 3881d223b0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libsolidity/codegen/ExpressionCompiler.cpp
View File

@ -453,6 +453,10 @@ bool ExpressionCompiler::visit(UnaryOperation const& _unaryOperation)
// unary add, so basically no-op // unary add, so basically no-op
break; break;
case Token::Sub: // - case Token::Sub: // -
solUnimplementedAssert(
type.category() != Type::Category::FixedPoint,
"Not yet implemented - FixedPointType."
);
if (m_context.arithmetic() == Arithmetic::Checked) if (m_context.arithmetic() == Arithmetic::Checked)
m_context.callYulFunction(m_context.utilFunctions().negateNumberCheckedFunction(type), 1, 1); m_context.callYulFunction(m_context.utilFunctions().negateNumberCheckedFunction(type), 1, 1);
else else

6
libsolidity/codegen/YulUtilFunctions.cpp
View File

@ -3484,6 +3484,7 @@ string YulUtilFunctions::forwardingRevertFunction()
std::string YulUtilFunctions::decrementCheckedFunction(Type const& _type) std::string YulUtilFunctions::decrementCheckedFunction(Type const& _type)
{ {
solAssert(_type.category() == Type::Category::Integer, "");
IntegerType const& type = dynamic_cast<IntegerType const&>(_type); IntegerType const& type = dynamic_cast<IntegerType const&>(_type);
string const functionName = "decrement_" + _type.identifier(); string const functionName = "decrement_" + _type.identifier();
@ -3506,6 +3507,7 @@ std::string YulUtilFunctions::decrementCheckedFunction(Type const& _type)
std::string YulUtilFunctions::decrementWrappingFunction(Type const& _type) std::string YulUtilFunctions::decrementWrappingFunction(Type const& _type)
{ {
solAssert(_type.category() == Type::Category::Integer, "");
IntegerType const& type = dynamic_cast<IntegerType const&>(_type); IntegerType const& type = dynamic_cast<IntegerType const&>(_type);
string const functionName = "decrement_wrapping_" + _type.identifier(); string const functionName = "decrement_wrapping_" + _type.identifier();
@ -3524,6 +3526,7 @@ std::string YulUtilFunctions::decrementWrappingFunction(Type const& _type)
std::string YulUtilFunctions::incrementCheckedFunction(Type const& _type) std::string YulUtilFunctions::incrementCheckedFunction(Type const& _type)
{ {
solAssert(_type.category() == Type::Category::Integer, "");
IntegerType const& type = dynamic_cast<IntegerType const&>(_type); IntegerType const& type = dynamic_cast<IntegerType const&>(_type);
string const functionName = "increment_" + _type.identifier(); string const functionName = "increment_" + _type.identifier();
@ -3546,6 +3549,7 @@ std::string YulUtilFunctions::incrementCheckedFunction(Type const& _type)
std::string YulUtilFunctions::incrementWrappingFunction(Type const& _type) std::string YulUtilFunctions::incrementWrappingFunction(Type const& _type)
{ {
solAssert(_type.category() == Type::Category::Integer, "");
IntegerType const& type = dynamic_cast<IntegerType const&>(_type); IntegerType const& type = dynamic_cast<IntegerType const&>(_type);
string const functionName = "increment_wrapping_" + _type.identifier(); string const functionName = "increment_wrapping_" + _type.identifier();
@ -3564,6 +3568,7 @@ std::string YulUtilFunctions::incrementWrappingFunction(Type const& _type)
string YulUtilFunctions::negateNumberCheckedFunction(Type const& _type) string YulUtilFunctions::negateNumberCheckedFunction(Type const& _type)
{ {
solAssert(_type.category() == Type::Category::Integer, "");
IntegerType const& type = dynamic_cast<IntegerType const&>(_type); IntegerType const& type = dynamic_cast<IntegerType const&>(_type);
solAssert(type.isSigned(), "Expected signed type!"); solAssert(type.isSigned(), "Expected signed type!");
@ -3586,6 +3591,7 @@ string YulUtilFunctions::negateNumberCheckedFunction(Type const& _type)
string YulUtilFunctions::negateNumberWrappingFunction(Type const& _type) string YulUtilFunctions::negateNumberWrappingFunction(Type const& _type)
{ {
solAssert(_type.category() == Type::Category::Integer, "");
IntegerType const& type = dynamic_cast<IntegerType const&>(_type); IntegerType const& type = dynamic_cast<IntegerType const&>(_type);
solAssert(type.isSigned(), "Expected signed type!"); solAssert(type.isSigned(), "Expected signed type!");