From 38639417e19250d106b0543aaa73b8c0389ba9da Mon Sep 17 00:00:00 2001 From: wechman Date: Fri, 18 Feb 2022 09:13:33 +0100 Subject: [PATCH] Non-fatal erros do not stop ASTJSON test execution --- test/libsolidity/ASTJSONTest.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/test/libsolidity/ASTJSONTest.cpp b/test/libsolidity/ASTJSONTest.cpp index 82c6e7e18..975c66be2 100644 --- a/test/libsolidity/ASTJSONTest.cpp +++ b/test/libsolidity/ASTJSONTest.cpp @@ -141,13 +141,13 @@ TestCase::TestResult ASTJSONTest::run(ostream& _stream, string const& _linePrefi if (!c.parseAndAnalyze(variant.stopAfter)) { - // Ignore non-fatal analysis errors, we only want to export. - if (c.state() > CompilerStack::State::Parsed) - continue; - - SourceReferenceFormatter formatter(_stream, c, _formatted, false); - formatter.printErrorInformation(c.errors()); - return TestResult::FatalError; + // We just want to export so raise fatal analysis errors only + if (c.state() < CompilerStack::State::ParsedAndImported) + { + SourceReferenceFormatter formatter(_stream, c, _formatted, false); + formatter.printErrorInformation(c.errors()); + return TestResult::FatalError; + } } resultsMatch = resultsMatch && runTest(