cerc-io/solidity
11
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Check invalid integer constants for functions accepting arbitrary arguments.

Browse Source
This commit is contained in:
chriseth
2015-10-07 18:13:20 +02:00
parent ab433c9a78
commit 35de03626f
2 changed files with 23 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libsolidity/TypeChecker.cpp
+10 -4
View File
@@ -824,10 +824,15 @@ bool TypeChecker::visit(FunctionCall const& _functionCall)
{
// call by positional arguments
for (size_t i = 0; i < arguments.size(); ++i)
if (
!functionType->takesArbitraryParameters() &&
!type(*arguments[i])->isImplicitlyConvertibleTo(*parameterTypes[i])
)
{
auto const& argType = type(*arguments[i]);
if (functionType->takesArbitraryParameters())
{
if (auto t = dynamic_cast<IntegerConstantType const*>(argType.get()))
if (!t->integerType())
typeError(*arguments[i], "Integer constant too large.");
}
else if (!type(*arguments[i])->isImplicitlyConvertibleTo(*parameterTypes[i]))
typeError(
*arguments[i],
"Invalid type for argument in function call. "
@@ -837,6 +842,7 @@ bool TypeChecker::visit(FunctionCall const& _functionCall)
parameterTypes[i]->toString() +
" requested."
);
}
}
else
{