From 34c06c27a5658b6b65d80d64d9cc684f8e1eddf4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kamil=20=C5=9Aliwak?= Date: Mon, 28 Mar 2022 17:56:30 +0200 Subject: [PATCH] Downgrade ethers.js to 5.6.1 in ens, gnosis, euler, perpetual-pools and uniswap external tests --- test/externalTests/ens.sh | 4 ++++ test/externalTests/euler.sh | 4 ++++ test/externalTests/gnosis.sh | 4 ++++ test/externalTests/perpetual-pools.sh | 4 ++++ test/externalTests/uniswap.sh | 4 ++++ 5 files changed, 20 insertions(+) diff --git a/test/externalTests/ens.sh b/test/externalTests/ens.sh index e4edbf46c..bf018d0ce 100755 --- a/test/externalTests/ens.sh +++ b/test/externalTests/ens.sh @@ -65,6 +65,10 @@ function ens_test force_hardhat_compiler_settings "$config_file" "$(first_word "$SELECTED_PRESETS")" yarn install + # With ethers.js 5.6.2 many tests for revert messages fail. + # TODO: Remove when https://github.com/ethers-io/ethers.js/discussions/2849 is resolved. + yarn add ethers@5.6.1 + replace_version_pragmas neutralize_packaged_contracts diff --git a/test/externalTests/euler.sh b/test/externalTests/euler.sh index 39283bcd5..0d63ecd43 100755 --- a/test/externalTests/euler.sh +++ b/test/externalTests/euler.sh @@ -68,6 +68,10 @@ function euler_test force_hardhat_unlimited_contract_size "$config_file" npm install + # With ethers.js 5.6.2 many tests for revert messages fail. + # TODO: Remove when https://github.com/ethers-io/ethers.js/discussions/2849 is resolved. + npm install ethers@5.6.1 + replace_version_pragmas neutralize_packaged_contracts diff --git a/test/externalTests/gnosis.sh b/test/externalTests/gnosis.sh index ccfc6cf5c..b8553e4eb 100755 --- a/test/externalTests/gnosis.sh +++ b/test/externalTests/gnosis.sh @@ -81,6 +81,10 @@ function gnosis_safe_test npm install npm install hardhat-gas-reporter + # With ethers.js 5.6.2 many tests for revert messages fail. + # TODO: Remove when https://github.com/ethers-io/ethers.js/discussions/2849 is resolved. + npm install ethers@5.6.1 + replace_version_pragmas [[ $BINARY_TYPE == solcjs ]] && force_solc_modules "${DIR}/solc/dist" diff --git a/test/externalTests/perpetual-pools.sh b/test/externalTests/perpetual-pools.sh index 7e4289698..51d729d5d 100755 --- a/test/externalTests/perpetual-pools.sh +++ b/test/externalTests/perpetual-pools.sh @@ -71,6 +71,10 @@ function perpetual_pools_test # TODO: Remove when https://github.com/OpenZeppelin/openzeppelin-upgrades/issues/528 is fixed. yarn add hardhat@2.8.4 + # With ethers.js 5.6.2 many tests for revert messages fail. + # TODO: Remove when https://github.com/ethers-io/ethers.js/discussions/2849 is resolved. + yarn add ethers@5.6.1 + replace_version_pragmas for preset in $SELECTED_PRESETS; do diff --git a/test/externalTests/uniswap.sh b/test/externalTests/uniswap.sh index 2f94c6abd..efea480b6 100755 --- a/test/externalTests/uniswap.sh +++ b/test/externalTests/uniswap.sh @@ -77,6 +77,10 @@ function uniswap_test yarn install yarn add hardhat-gas-reporter + # With ethers.js 5.6.2 many tests for revert messages fail. + # TODO: Remove when https://github.com/ethers-io/ethers.js/discussions/2849 is resolved. + yarn add ethers@5.6.1 + replace_version_pragmas for preset in $SELECTED_PRESETS; do