Merge pull request #4286 from ethereum/cli-formal

[BREAKING] Remove obsolete --formal option from CLI
This commit is contained in:
chriseth 2018-06-13 09:08:27 +02:00 committed by GitHub
commit 3055e4caa3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 8 deletions

View File

@ -3,6 +3,7 @@
Breaking Changes:
* ABI Encoder: Properly pad data from calldata (``msg.data`` and external function parameters). Use ``abi.encodePacked`` for unpadded encoding.
* Code Generator: Signed right shift uses proper arithmetic shift, i.e. rounding towards negative infinity. Warning: this may silently change the semantics of existing code!
* Commandline interface: Remove obsolete ``--formal`` option.
* Commandline interface: Require ``-`` if standard input is used as source.
* General: ``continue`` in a ``do...while`` loop jumps to the condition (it used to jump to the loop body). Warning: this may silently change the semantics of existing code.
* General: Disallow ``sha3`` and ``suicide`` aliases.

View File

@ -88,7 +88,6 @@ static string const g_strEVM = "evm";
static string const g_strEVM15 = "evm15";
static string const g_strEVMVersion = "evm-version";
static string const g_streWasm = "ewasm";
static string const g_strFormal = "formal";
static string const g_strGas = "gas";
static string const g_strHelp = "help";
static string const g_strInputFile = "input-file";
@ -132,7 +131,6 @@ static string const g_argBinaryRuntime = g_strBinaryRuntime;
static string const g_argCloneBinary = g_strCloneBinary;
static string const g_argCombinedJson = g_strCombinedJson;
static string const g_argCompactJSON = g_strCompactJSON;
static string const g_argFormal = g_strFormal;
static string const g_argGas = g_strGas;
static string const g_argHelp = g_strHelp;
static string const g_argInputFile = g_strInputFile;
@ -216,7 +214,6 @@ static bool needsHumanTargetedStdout(po::variables_map const& _args)
g_argBinary,
g_argBinaryRuntime,
g_argCloneBinary,
g_argFormal,
g_argMetadata,
g_argNatspecUser,
g_argNatspecDev,
@ -639,8 +636,7 @@ Allowed options)",
(g_argSignatureHashes.c_str(), "Function signature hashes of the contracts.")
(g_argNatspecUser.c_str(), "Natspec user documentation of all contracts.")
(g_argNatspecDev.c_str(), "Natspec developer documentation of all contracts.")
(g_argMetadata.c_str(), "Combined Metadata JSON whose Swarm hash is stored on-chain.")
(g_argFormal.c_str(), "Translated source suitable for formal analysis. (Deprecated)");
(g_argMetadata.c_str(), "Combined Metadata JSON whose Swarm hash is stored on-chain.");
desc.add(outputComponents);
po::options_description allOptions = desc;
@ -1236,9 +1232,6 @@ void CommandLineInterface::outputCompilationResults()
handleNatspec(true, contract);
handleNatspec(false, contract);
} // end of contracts iteration
if (m_args.count(g_argFormal))
cerr << "Support for the Why3 output was removed." << endl;
}
}