[SMTChecker] Added support for public getters through this.

test/libsolidity/smtCheckerTests/functions/getters/address.sol

@@ -0,0 +1,18 @@
+pragma experimental SMTChecker;
+
+contract C {
+	address public x;
+	address payable public y;
+
+	function f() public view {
+		address a = this.x();
+		address b = this.y();
+		assert(a == x); // should hold
+		assert(a == address(this)); // should fail
+		assert(b == y); // should hold
+		assert(y == address(this)); // should fail
+	}
+}
+// ----
+// Warning 6328: (204-230): CHC: Assertion violation happens here.
+// Warning 6328: (282-308): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/array_1.sol

@@ -0,0 +1,13 @@
+pragma experimental SMTChecker;
+
+contract C {
+	uint[] public a;
+
+	function f() public view {
+		uint y = this.a(2);
+		assert(y == a[2]); // should hold
+		assert(y == 1); // should fail
+	}
+}
+// ----
+// Warning 6328: (153-167): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/array_2.sol

@@ -0,0 +1,13 @@
+pragma experimental SMTChecker;
+
+contract C {
+	uint[][] public a;
+
+	function f() public view {
+		uint y = this.a(2,3);
+		assert(y == a[2][3]); // should hold
+		assert(y == 1); // should fail
+	}
+}
+// ----
+// Warning 6328: (160-174): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/bytes.sol

@@ -0,0 +1,13 @@
+pragma experimental SMTChecker;
+
+contract C {
+	bytes public str2 = 'c';
+
+	function f() public view {
+		bytes memory a2 = this.str2();
+		assert(keccak256(a2) == keccak256(str2)); // should hold
+		assert(keccak256(a2) == keccak256('a')); // should fail
+	}
+}
+// ----
+// Warning 6328: (195-234): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/contract.sol

@@ -0,0 +1,15 @@
+pragma experimental SMTChecker;
+
+contract D {}
+
+contract C {
+	D public d;
+
+	function f() public view {
+		D e = this.d();
+		assert(e == d); // should hold
+		assert(address(e) == address(this)); // should fail
+	}
+}
+// ----
+// Warning 6328: (156-191): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/double_access.sol

@@ -0,0 +1,19 @@
+pragma experimental SMTChecker;
+
+contract C {
+	struct S {
+		uint u;
+	}
+
+	S public s;
+
+	function f() public view {
+		uint u = this.s();
+		uint v = this.s();
+		assert(u == s.u); // should hold
+		assert(u == v); // should hold
+		assert(u == 1); // should fail
+	}
+}
+// ----
+// Warning 6328: (226-240): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/enum.sol

@@ -0,0 +1,15 @@
+pragma experimental SMTChecker;
+
+
+contract C {
+	enum ActionChoices { GoLeft, GoRight, GoStraight, SitStill }
+	ActionChoices public choice;
+
+	function f() public view {
+		ActionChoices e = this.choice();
+		assert(e == choice); // should hold
+		assert(e == ActionChoices.SitStill); // should fail
+	}
+}
+// ----
+// Warning 6328: (243-278): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/fixed_bytes.sol

@@ -0,0 +1,18 @@
+pragma experimental SMTChecker;
+
+contract C {
+	byte public x;
+	bytes3 public y;
+
+	function f() public view {
+		byte a = this.x();
+		bytes3 b = this.y();
+		assert(a == x); // should hold
+		assert(a == 'a'); // should fail
+		assert(b == y); // should hold
+		assert(y == "abc"); // should fail
+	}
+}
+// ----
+// Warning 6328: (188-204): CHC: Assertion violation happens here.
+// Warning 6328: (256-274): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/function.sol

@@ -0,0 +1,19 @@
+pragma experimental SMTChecker;
+
+contract C {
+	function () external returns (uint) public g;
+
+	function f() public {
+		g = this.X;
+		function () external returns (uint) e = this.g();
+		assert(e() == g()); // should hold, but fails because of the lack of support for tracking function pointers
+		assert(e() == 1); // should fail
+	}
+
+	function X() public pure returns (uint) {
+		return 42;
+	}
+}
+// ----
+// Warning 6328: (185-203): CHC: Assertion violation happens here.
+// Warning 6328: (295-311): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/mapping_1.sol

@@ -0,0 +1,13 @@
+pragma experimental SMTChecker;
+
+contract C {
+	mapping (uint => uint) public map;
+
+	function f() public view {
+		uint y = this.map(2);
+		assert(y == map[2]); // should hold
+		assert(y == 1); // should fail
+	}
+}
+// ----
+// Warning 6328: (175-189): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/mapping_2.sol

@@ -5,8 +5,9 @@ contract C {
 
 	function f() public view {
 		uint y = this.map(2, 3);
-		assert(y == map[2][3]); // This fails as false positive because of lack of support for external getters.
+		assert(y == map[2][3]); // should hold
+		assert(y == 1); // should fail
 	}
 }
 // ----
-// Warning 6328: (158-180): CHC: Assertion violation happens here.
+// Warning 6328: (199-213): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/mapping_with_cast.sol

@@ -0,0 +1,13 @@
+pragma experimental SMTChecker;
+
+contract C {
+	mapping (bytes16 => uint) public m;
+
+	function f() public view {
+		uint y = this.m("foo");
+		assert(y == m["foo"]); // should hold
+		assert(y == 1); // should fail
+	}
+}
+// ----
+// Warning 6328: (180-194): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/nested_arrays_mappings_1.sol

@@ -0,0 +1,19 @@
+pragma experimental SMTChecker;
+
+contract C {
+	mapping (uint => uint[]) public m;
+
+	constructor() {
+		m[0].push();
+		m[0].push();
+		m[0][1] = 42;
+	}
+
+	function f() public view {
+		uint y = this.m(0,1);
+		assert(y == m[0][1]); // should hold
+		assert(y == 1); // should fail
+	}
+}
+// ----
+// Warning 6328: (243-257): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/nested_arrays_mappings_10.sol

@@ -0,0 +1,21 @@
+pragma experimental SMTChecker;
+
+contract C {
+	mapping (uint => uint[])[] public m;
+
+	constructor() {
+		m.push();
+		m[0][1].push();
+		m[0][1].push();
+		m[0][1].push();
+		m[0][1][2] = 42;
+	}
+
+	function f() public view {
+		uint y = this.m(0,1,2);
+		assert(y == m[0][1][2]); // should hold
+		assert(y == 1); // should fail
+	}
+}
+// ----
+// Warning 6328: (289-303): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/nested_arrays_mappings_2.sol

@@ -0,0 +1,22 @@
+pragma experimental SMTChecker;
+
+contract C {
+	mapping (uint => uint[][]) public m;
+
+	constructor() {
+		m[0].push();
+		m[0].push();
+		m[0][1].push();
+		m[0][1].push();
+		m[0][1].push();
+		m[0][1][2] = 42;
+	}
+
+	function f() public view {
+		uint y = this.m(0,1,2);
+		assert(y == m[0][1][2]); // should hold
+		assert(y == 1); // should fail
+	}
+}
+// ----
+// Warning 6328: (307-321): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/nested_arrays_mappings_3.sol

@@ -0,0 +1,26 @@
+pragma experimental SMTChecker;
+
+contract C {
+	mapping (uint => uint[][][]) public m;
+
+	constructor() {
+		m[0].push();
+		m[0].push();
+		m[0][1].push();
+		m[0][1].push();
+		m[0][1].push();
+		m[0][1][2].push();
+		m[0][1][2].push();
+		m[0][1][2].push();
+		m[0][1][2].push();
+		m[0][1][2][3] = 42;
+	}
+
+	function f() public view {
+		uint y = this.m(0,1,2,3);
+		assert(y == m[0][1][2][3]); // should hold
+		assert(y == 1); // should fail
+	}
+}
+// ----
+// Warning 6328: (401-415): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/nested_arrays_mappings_4.sol

@@ -0,0 +1,20 @@
+pragma experimental SMTChecker;
+
+contract C {
+	mapping (uint => mapping (uint => uint[])) public m;
+
+	constructor() {
+		m[0][1].push();
+		m[0][1].push();
+		m[0][1].push();
+		m[0][1][2] = 42;
+	}
+
+	function f() public view {
+		uint y = this.m(0,1,2);
+		assert(y == m[0][1][2]); // should hold
+		assert(y == 1); // should fail
+	}
+}
+// ----
+// Warning 6328: (293-307): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/nested_arrays_mappings_5.sol

@@ -0,0 +1,24 @@
+pragma experimental SMTChecker;
+
+contract C {
+	mapping (uint => mapping (uint => uint[][])) public m;
+
+	constructor() {
+		m[0][1].push();
+		m[0][1].push();
+		m[0][1].push();
+		m[0][1][2].push();
+		m[0][1][2].push();
+		m[0][1][2].push();
+		m[0][1][2].push();
+		m[0][1][2][3] = 42;
+	}
+
+	function f() public view {
+		uint y = this.m(0,1,2,3);
+		assert(y == m[0][1][2][3]); // should hold
+		assert(y == 1); // should fail
+	}
+}
+// ----
+// Warning 6328: (387-401): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/nested_arrays_mappings_6.sol

@@ -0,0 +1,21 @@
+pragma experimental SMTChecker;
+
+contract C {
+	mapping (uint => mapping (uint => mapping (uint => uint[]))) public m;
+
+	constructor() {
+		m[0][1][2].push();
+		m[0][1][2].push();
+		m[0][1][2].push();
+		m[0][1][2].push();
+		m[0][1][2][3] = 42;
+	}
+
+	function f() public view {
+		uint y = this.m(0,1,2,3);
+		assert(y == m[0][1][2][3]); // should hold
+		assert(y == 1); // should fail
+	}
+}
+// ----
+// Warning 6328: (349-363): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/nested_arrays_mappings_7.sol

@@ -0,0 +1,18 @@
+pragma experimental SMTChecker;
+
+contract C {
+	mapping (uint => uint)[] public m;
+
+	constructor() {
+		m.push();
+		m[0][1] = 42;
+	}
+
+	function f() public view {
+		uint y = this.m(0,1);
+		assert(y == m[0][1]); // should hold
+		assert(y == 1); // should fail
+	}
+}
+// ----
+// Warning 6328: (225-239): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/nested_arrays_mappings_8.sol

@@ -0,0 +1,20 @@
+pragma experimental SMTChecker;
+
+contract C {
+	mapping (uint => uint)[][] public m;
+
+	constructor() {
+		m.push();
+		m[0].push();
+		m[0].push();
+		m[0][1][2] = 42;
+	}
+
+	function f() public view {
+		uint y = this.m(0,1,2);
+		assert(y == m[0][1][2]); // should hold
+		assert(y == 1); // should fail
+	}
+}
+// ----
+// Warning 6328: (265-279): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/nested_arrays_mappings_9.sol

@@ -0,0 +1,18 @@
+pragma experimental SMTChecker;
+
+contract C {
+	mapping (uint => mapping (uint => uint))[] public m;
+
+	constructor() {
+		m.push();
+		m[0][1][2] = 42;
+	}
+
+	function f() public view {
+		uint y = this.m(0,1,2);
+		assert(y == m[0][1][2]); // should hold
+		assert(y == 1); // should fail
+	}
+}
+// ----
+// Warning 6328: (251-265): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/static_array.sol

@@ -0,0 +1,15 @@
+pragma experimental SMTChecker;
+
+
+contract C {
+
+	uint[2] public x = [42,1];
+
+	function f() public view {
+		assert(this.x(0) == x[0]); // should hold
+		assert(this.x(1) == x[1]); // should hold
+		assert(this.x(0) == 0); // should fail
+	}
+}
+// ----
+// Warning 6328: (195-217): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/string.sol

@@ -0,0 +1,13 @@
+pragma experimental SMTChecker;
+
+contract C {
+	string public str1 = 'b';
+
+	function f() public view {
+		string memory a1 = this.str1();
+		assert(keccak256(bytes(a1)) == keccak256(bytes(str1))); // should hold
+		assert(keccak256(bytes(a1)) == keccak256('a')); // should fail
+	}
+}
+// ----
+// Warning 6328: (211-257): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/struct_1.sol

@@ -0,0 +1,29 @@
+pragma experimental SMTChecker;
+pragma abicoder v2;
+
+contract C {
+	struct T {
+		uint t;
+	}
+	struct S {
+		uint x;
+		T t;
+		bool b;
+		uint[] a;
+	}
+
+	S public s;
+
+	function f() public view {
+		uint y;
+		bool c;
+		T memory t;
+		(y,t,c) = this.s();
+		assert(y == s.x); // this should hold
+		assert(c == s.b); // this should hold
+		assert(t.t == s.t.t); // this should hold
+		assert(c == true); // this should fail
+	}
+}
+// ----
+// Warning 6328: (370-387): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/struct_2.sol

@@ -0,0 +1,19 @@
+pragma experimental SMTChecker;
+//pragma abicoder v2;
+
+contract C {
+	struct S {
+		uint[2] a;
+		uint u;
+	}
+
+	S public s;
+
+	function f() public view {
+		uint u = this.s();
+		assert(u == s.u); // should hold
+		assert(u == 1); // should fail
+	}
+}
+// ----
+// Warning 6328: (207-221): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/struct_3.sol

@@ -0,0 +1,24 @@
+pragma experimental SMTChecker;
+
+contract C {
+	struct S {
+		string s;
+		bytes b;
+	}
+
+	S public m;
+
+	constructor() {
+		m.s = "foo";
+		m.b = "bar";
+	}
+
+	function f() public view {
+		(string memory s, bytes memory b) = this.m();
+		assert(keccak256(bytes(s)) == keccak256(bytes(m.s))); // should hold
+		assert(b[0] == m.b[0]); // should hold
+		assert(b[0] == "t"); // should fail
+	}
+}
+// ----
+// Warning 6328: (340-359): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/struct_4.sol

@@ -0,0 +1,22 @@
+pragma experimental SMTChecker;
+
+contract D {
+}
+
+contract C {
+	struct S {
+		D d;
+		function () external returns (uint) f;
+	}
+
+	S public s;
+
+	function test() public view {
+		(D d, function () external returns (uint) f) = this.s();
+		assert(d == s.d); // should hold
+		assert(address(d) == address(this)); // should fail
+	}
+}
+// ----
+// Warning 2072: (179-216): Unused local variable.
+// Warning 6328: (267-302): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/struct_with_reassignment.sol

@@ -0,0 +1,32 @@
+pragma experimental SMTChecker;
+
+contract C {
+	struct S {
+		uint x;
+		bool b;
+	}
+
+	S public s;
+
+	constructor() {
+		s.x = 1;
+		s.b = false;
+	}
+
+	function f() public {
+		uint x;
+		bool b;
+		(x,b) = this.s();
+		assert(x == s.x); // this should hold
+		assert(b == s.b); // this should hold
+		assert(b == true); // this should fail
+		s.x = 42;
+		(uint y, bool c) = this.s();
+		assert(c == b); // this should hold
+		assert(y == x); // this should fail
+
+	}
+}
+// ----
+// Warning 6328: (288-305): CHC: Assertion violation happens here.
+// Warning 6328: (410-424): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/getters/uint.sol

@@ -0,0 +1,13 @@
+pragma experimental SMTChecker;
+
+contract C {
+	uint public x;
+
+	function f() public view {
+		uint y = this.x();
+		assert(y == x); // should hold
+		assert(y == 1); // should fail
+	}
+}
+// ----
+// Warning 6328: (147-161): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/this_external_getter_1.sol

@@ -1,12 +0,0 @@
-pragma experimental SMTChecker;
-
-contract C {
-	uint public x;
-
-	function f() public view {
-		uint y = this.x();
-		assert(y == x); // This fails as false positive because of lack of support for external getters.
-	}
-}
-// ----
-// Warning 6328: (114-128): CHC: Assertion violation happens here.

test/libsolidity/smtCheckerTests/functions/this_external_getter_2.sol

@@ -1,12 +0,0 @@
-pragma experimental SMTChecker;
-
-contract C {
-	mapping (uint => uint) public map;
-
-	function f() public view {
-		uint y = this.map(2);
-		assert(y == map[2]); // This fails as false positive because of lack of support for external getters.
-	}
-}
-// ----
-// Warning 6328: (137-156): CHC: Assertion violation happens here.